Skip to content

[gen_l10n] Throw error when arb file does not exist#107583

Merged
auto-submit[bot] merged 4 commits intoflutter:masterfrom
thkim1011:tae/fix-error-message
Jul 15, 2022
Merged

[gen_l10n] Throw error when arb file does not exist#107583
auto-submit[bot] merged 4 commits intoflutter:masterfrom
thkim1011:tae/fix-error-message

Conversation

@thkim1011
Copy link
Contributor

@thkim1011 thkim1011 commented Jul 13, 2022 •
edited
Loading

Currently, attempting to generate localization files checks for permissions on the template arb file but does not check whether the file exists or not. This PR changes this so that a more helpful error is thrown.

#106139

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 13, 2022
@thkim1011 thkim1011 changed the title draft [gen_l10n] Throw error when arb file does not exist Jul 15, 2022
@thkim1011 thkim1011 marked this pull request as ready for review July 15, 2022 16:08
@thkim1011 thkim1011 requested review from HansMuller and Piinks July 15, 2022 16:08
HansMuller
HansMuller reviewed Jul 15, 2022
View reviewed changes
packages/flutter_tools/lib/src/localizations/gen_l10n.dart Outdated
final String templateArbFileStatModeString = templateArbFileStat.modeString();
final FileSystemEntityType templateArbFileStatType = templateArbFileStat.type;
if (templateArbFileStatType == FileSystemEntityType.notFound) {
final String templateArbFileStatModeString = templateArbFile.statSync().modeString();
Copy link
Contributor

@HansMuller HansMuller Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable isn't used

Copy link
Contributor Author

@thkim1011 thkim1011 Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used in line 952 to check the permissions of the file, I think. I can put it right before that if-block if it makes it clearer.

Copy link
Contributor

@HansMuller HansMuller Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all good, my mistake. See below.

packages/flutter_tools/lib/src/localizations/gen_l10n.dart Outdated
if (templateArbFileStatType == FileSystemEntityType.notFound) {
final String templateArbFileStatModeString = templateArbFile.statSync().modeString();
final bool templateArbFileExists = templateArbFile.existsSync();
if (!templateArbFileExists) {
Copy link
Contributor

@HansMuller HansMuller Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could just be if (!templateArbFile.existsSync())

Copy link
Contributor

@HansMuller HansMuller Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was looking at the diffs not at the overall context. The version of the code you had originally, that just relied on one stat call made sense as it was. Sorry about the (my) confusion.

@thkim1011 thkim1011 requested a review from HansMuller July 15, 2022 16:37
HansMuller
HansMuller approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thkim1011 thkim1011 added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 15, 2022
@auto-submit auto-submit bot merged commit 2da2285 into flutter:master Jul 15, 2022
This was referenced Jul 16, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
34bd454 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
d3cdec9 
…flutter#107583)
@thkim1011 thkim1011 mentioned this pull request Jul 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
1a1bbcc 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
dd5b3c6 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
4243a56 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
aec6d3d 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
fef091f 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
4a0c65a 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
620b246 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
e866aba 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
159ec14 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
322b04c 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
371e72a 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
b6e3f96 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
476e6f9 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
1f5463c 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
160436c 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
d1129eb 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
d3b2f7a 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
1f799e3 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
6bc5500 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
5fe9c04 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
3bb8212 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
651b209 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
1e33cbc 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
2ed0e3f 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
24e56a6 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
dad0533 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
d558582 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
2647dae 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
4681731 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
2d3e0b0 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
a193f35 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
cfa2e62 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
1c790ea 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
545c1ee 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
d69a15f 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
f22b2ec 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
a5813a8 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
5188c9b 
…flutter#107583)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
2da2285 [gen_l10n] Throw error when arb file does not exist (flutter/…
d018a88 
…flutter#107583)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@thkim1011 @camsim99
[gen_l10n] Throw error when arb file does not exist (flutter#107583)
209b5f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Awaiting requested review from Piinks

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thkim1011 @HansMuller