Skip to content

Increase app minimum supported macOS version from 10.11 to 10.13#107689

Merged
jmagman merged 1 commit intoflutter:masterfrom
jmagman:mac-min-version
Jul 15, 2022
Merged

Increase app minimum supported macOS version from 10.11 to 10.13#107689
jmagman merged 1 commit intoflutter:masterfrom
jmagman:mac-min-version

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jul 15, 2022 •
edited
Loading

Increase minimum Flutter app target macOS version from 10.11 to macOS 10.13 High Sierra and higher.

  1. Change templates to MACOSX_DEPLOYMENT_TARGET and Podfile platform :osx to 10.13.
  2. Add migrator for these settings for existing apps.
  3. Run migrator on all example apps and integration tests.

This does not include upping the plugin templates, as those need to wait until the 10.13 framework reaches stable so new plugins can actually build with stable flutter created apps, see #89695 for details.

Similar iOS migration at #101963
Fixes #107688
Fixes #57805
Part of #107492.
Will unblock flutter/buildroot#588

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. platform-mac Building on or for macOS specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels Jul 15, 2022
@jmagman jmagman self-assigned this Jul 15, 2022
@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos platform-ios iOS applications specifically c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 15, 2022
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Jul 15, 2022

As an added bonus, this will "fix" #57805 :)

@jmagman jmagman requested review from cbracken and zanderso July 15, 2022 18:01
@jmagman
Copy link
Member Author

jmagman commented Jul 15, 2022

@zanderso any timing concerns with this? Or is this okay to merge?

jmagman
jmagman commented Jul 15, 2022
View reviewed changes
packages/flutter_tools/test/general.shard/macos/macos_project_migration_test.dart
testWithoutContext('skips migrating script with embed', () {
const String contents = r'''
group('remove link and embed migration', () {
late TestUsage testUsage;
Copy link
Member Author

@jmagman jmagman Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the group so this part is a whitespace only change.

packages/flutter_tools/test/general.shard/macos/macos_project_migration_test.dart
'migration fails with leftover FlutterMacOS.framework reference', () {
xcodeProjectInfoFile.writeAsStringSync('''
33D1A10522148B93bogus /* FlutterMacOS.framework in Bundle Framework */,
group('update deployment target version', () {
Copy link
Member Author

@jmagman jmagman Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the new tests.

zanderso
zanderso approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No timing concerns.

@jmagman
Copy link
Member Author

jmagman commented Jul 15, 2022

Google testing is stalled due to omg/55671, I was told to merge manually 🙂

@jmagman jmagman merged commit c4975d9 into flutter:master Jul 15, 2022
@jmagman jmagman deleted the mac-min-version branch July 15, 2022 18:12
This was referenced Jul 15, 2022
Closed
Closed
@stuartmorgan-g stuartmorgan-g mentioned this pull request Jul 15, 2022
Merged
This was referenced Jul 15, 2022
Closed
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
646c284 
….13 (flutter/flutter#107689)
cbracken
cbracken reviewed Jul 18, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
9a3a285 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
716ef7c 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
9059a35 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
917979a 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
9704e8e 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
655f991 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
0e04cd5 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
af727d6 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
ac05ab0 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
c985595 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
397f5ad 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
ce2c5a3 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
8b95db9 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
deb1444 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
265e48d 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
5b9962d 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
6e0b84f 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
a7a2593 
….13 (flutter/flutter#107689)
@jmagman jmagman mentioned this pull request Jul 26, 2022
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
597419f 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
6c46464 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
b66bb4c 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
fdb2c34 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
c9ff980 
….13 (flutter/flutter#107689)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
c4975d9 Increase app minimum supported macOS version from 10.11 to 10…
c7460fa 
….13 (flutter/flutter#107689)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@jmagman @camsim99
Increase app minimum supported macOS version from 10.11 to 10.13 (flu…
78670e7 
…tter#107689)
@huycozy huycozy mentioned this pull request Aug 24, 2022
Closed
@cbracken cbracken mentioned this pull request Nov 4, 2022
Merged
8 tasks
cbracken added a commit that referenced this pull request Nov 7, 2022
@cbracken
Increase minimum supported macOS version from 10.13 to 10.14 (#114713)
3c9288c 
Increases the minimum macOS deployment target from macOS 10.13 (High Sierra) to 10.14 (Mojave) in the macOS app templates.

Includes:
* Update migration for macOS 10.11 apps to upgrade to 10.14
* Adds migration for macOS 10.13 apps to upgrade to 10.14
* Apply migration to all examples, and integration tests

This does not increase version in the plugin templates since those will need to wait until the 10.14 framework rolls to stable channel, so new plugins can build with apps created with `flutter create` on stable channel.

Issue: #114445
See RFC: http://flutter.dev/go/flutter-drop-macOS-10.13-2022-q4
See previous patch: #107689
@darshankawar darshankawar mentioned this pull request Dec 2, 2022
Closed
@FeodorFitsner FeodorFitsner mentioned this pull request Dec 29, 2022
Closed
@frankmorgner frankmorgner mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken left review comments

@zanderso zanderso zanderso approved these changes

+1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos platform-ios iOS applications specifically platform-mac Building on or for macOS specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

5 participants

@jmagman @stuartmorgan-g @cbracken @zanderso @dnfield