Skip to content

Fix BottomNavigationBarItem tooltip defaults to label#107715

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
NevercodeHQ:fix_bottom_navigation_bar_item_tooltip_should_not_default_to_label
Jul 21, 2022
Merged

Fix BottomNavigationBarItem tooltip defaults to label#107715
auto-submit[bot] merged 1 commit intoflutter:masterfrom
NevercodeHQ:fix_bottom_navigation_bar_item_tooltip_should_not_default_to_label

Conversation

@bleroux
Copy link
Contributor

@bleroux bleroux commented Jul 15, 2022

Description

This PR updates BottomNavigationBar to not show a tooltip when BottomNavigationBarItem.tooltip is null (instead of displaying the label text).

Related Issue

Fixes #107036

Tests

Updates 1 test.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 15, 2022
@bleroux bleroux mentioned this pull request Jul 15, 2022
Closed
@bleroux bleroux requested a review from gspencergoog July 15, 2022 12:17
gspencergoog
gspencergoog approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Just some documentation nits.

packages/flutter/lib/src/widgets/bottom_navigation_bar_item.dart Outdated
Comment on lines 86 to 87
Copy link
Contributor

@gspencergoog gspencergoog Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say something like this instead:

  /// A [Tooltip] will only appear on this item if `tooltip` is set to a non-empty string..

packages/flutter/lib/src/widgets/bottom_navigation_bar_item.dart Outdated
Copy link
Contributor

@gspencergoog gspencergoog Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// The text to display in the tooltip for this [BottomNavigationBarItem].
/// The text to display in the [Tooltip] for this [BottomNavigationBarItem].

@bleroux bleroux force-pushed the fix_bottom_navigation_bar_item_tooltip_should_not_default_to_label branch 2 times, most recently from 06e685f to d87ae16 Compare July 20, 2022 14:06
@bleroux bleroux force-pushed the fix_bottom_navigation_bar_item_tooltip_should_not_default_to_label branch from d87ae16 to 65609c8 Compare July 20, 2022 19:35
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2022
@auto-submit auto-submit bot merged commit d263cfb into flutter:master Jul 21, 2022
@bleroux bleroux deleted the fix_bottom_navigation_bar_item_tooltip_should_not_default_to_label branch July 21, 2022 04:22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
ac79027 
…r/flutter#107715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
8cf045d 
…r/flutter#107715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
6f2c3a4 
…r/flutter#107715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
7b0286a 
…r/flutter#107715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
f6f052b 
…r/flutter#107715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
9b2b482 
…r/flutter#107715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
16ce1d2 
…r/flutter#107715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
1d8f79e 
…r/flutter#107715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
9955331 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
cf3c836 
…r/flutter#107715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
97c63ed 
…r/flutter#107715)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
a6bd6a2 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
cf5403c 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
7e5b5ea 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
a7c8c6c 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
2c3a3c6 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
c78de76 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
f06d8df 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
8617088 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
8573890 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
dc7658a 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
9f84c0d 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
b77eccf 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
102c14c 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
fa0360e 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
f6ad489 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
86abfb4 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
d114d40 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
ec19d04 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
425ac56 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
586890d 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
8083680 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
728d134 
…r/flutter#107715)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
d263cfb Fix BottomNavigationBarItem tooltip defaults to label (flutte…
2ded3d8 
…r/flutter#107715)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@bleroux @camsim99
Fix BottomNavigationBarItem tooltip defaults to label (flutter#107715)
651243d
@Nirajn2311 Nirajn2311 mentioned this pull request Feb 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BottomNavigationBarItem's tooltip should not use the label text as a default

2 participants

@bleroux @gspencergoog