Skip to content

add page delays to the fullscreen versions of the textfield perf benchmarks#107746

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
flar:add-fullscreen-text-perf-page-delay
Aug 11, 2022
Merged

add page delays to the fullscreen versions of the textfield perf benchmarks#107746
auto-submit[bot] merged 2 commits intoflutter:masterfrom
flar:add-fullscreen-text-perf-page-delay

Conversation

@flar
Copy link
Contributor

@flar flar commented Jul 15, 2022

This is similar to what was done with #107500 for the non-fullscreen versions. The page delay keeps us from measuring the page transition time.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jul 15, 2022
@flar flar requested a review from LongCatIsLooong July 15, 2022 20:49
@flar flar mentioned this pull request Jul 15, 2022
Merged
LongCatIsLooong
LongCatIsLooong reviewed Jul 15, 2022
View reviewed changes
dev/benchmarks/macrobenchmarks/test/fullscreen_textfield_perf_e2e.dart Outdated
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be removed?

Copy link
Contributor Author

@flar flar Jul 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, actually, I think I was doing a quick manual A/B test before pushing it and forgot to put it back.

Copy link
Contributor Author

@flar flar Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored...

@flar flar force-pushed the add-fullscreen-text-perf-page-delay branch from f42d39a to 007f3c4 Compare August 11, 2022 06:29
@flar flar requested a review from LongCatIsLooong August 11, 2022 06:29
@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2022
@auto-submit auto-submit bot merged commit fe70a2b into flutter:master Aug 11, 2022
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
ef13d24 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
dfd2312 
…erf benchmarks (flutter/flutter#107746)
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
7b958af 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
a67afd0 
…erf benchmarks (flutter/flutter#107746)
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
7c58fe9 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
829f45d 
…erf benchmarks (flutter/flutter#107746)
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
5235523 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
ebd14cd 
…erf benchmarks (flutter/flutter#107746)
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
3878bba 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
89e7b9a 
…erf benchmarks (flutter/flutter#107746)
This was referenced Aug 13, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
4b2a94d 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
5e8f58c 
…erf benchmarks (flutter/flutter#107746)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
fd04690 
…erf benchmarks (flutter/flutter#107746)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
ad0df48 
…erf benchmarks (flutter/flutter#107746)
This was referenced Aug 14, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
9921700 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
987d0be 
…erf benchmarks (flutter/flutter#107746)
This was referenced Aug 14, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
7e26247 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
e38a523 
…erf benchmarks (flutter/flutter#107746)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
b871615 
…erf benchmarks (flutter/flutter#107746)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
cfd6958 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
dafb750 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
8d45007 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
05593b9 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
71edc49 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
71b5140 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
74db355 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
d03fd39 
…erf benchmarks (flutter/flutter#107746)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
fe70a2b add page delays to the fullscreen versions of the textfield p…
f1b7690 
…erf benchmarks (flutter/flutter#107746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flar @LongCatIsLooong