Skip to content

Expose padding on RawScrollbar#107756

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Piinks:padBar
Jul 19, 2022
Merged

Expose padding on RawScrollbar#107756
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Piinks:padBar

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Jul 15, 2022

Full context: #107172 (comment)

Allows the user to configure padding on the scrollbar thumb & track.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. a: quality A truly polished experience labels Jul 15, 2022
@Piinks Piinks requested a review from xu-baolin July 15, 2022 22:46
@xu-baolin
Copy link
Member

xu-baolin commented Jul 15, 2022

Add to the 'Scrollbar' widget too?

@Piinks
Copy link
Contributor Author

Piinks commented Jul 18, 2022

Add to the 'Scrollbar' widget too?

I am hesitant to do that, since that widget also does not expose margins. It feels like a slippery slope, if you add one, why not the others?

The Material scrollbar follows Material Design, and along with the Cupertino one, they are based on the native specifications. We try to avoid enumerating a lot of properties unless they are necessary, it leads to a bloated API. Usually on the lower level Raw* classes is where we have a lot of the lower level fine tuning available.

What do you think?

@xu-baolin
Copy link
Member

xu-baolin commented Jul 19, 2022

Add to the 'Scrollbar' widget too?

I am hesitant to do that, since that widget also does not expose margins. It feels like a slippery slope, if you add one, why not the others?

The Material scrollbar follows Material Design, and along with the Cupertino one, they are based on the native specifications. We try to avoid enumerating a lot of properties unless they are necessary, it leads to a bloated API. Usually on the lower level Raw* classes is where we have a lot of the lower level fine tuning available.

What do you think?

Make sense.

xu-baolin
xu-baolin approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@xu-baolin xu-baolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xu-baolin xu-baolin added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2022
@auto-submit auto-submit bot merged commit f852c46 into flutter:master Jul 19, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
027de62
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
383d3e8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
7df5092
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
2e1c252
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
af9bc7e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
7a573c5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
fc969f2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
1777e1b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
c3ff7b1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
92d6d51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
2097e45
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
e38f3ab
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
defdbd7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
1a83b5f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
0a98a92
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
b3a575e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
1049bc3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
8353811
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
1f85706
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
da12ac3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
a675897
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
c8bc81f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
0a3a6a6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
413ea23
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
3db0334
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
6ac4aef
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
149f158
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
f06e4f3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
32f7cbc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
6ec200e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
d557f3b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
768e244
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
ee25a21
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
cca1443
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
f852c46 Expose padding on RawScrollbar (flutter/flutter#107756)
a3ce2f6
This was referenced Aug 2, 2022
Merged
Closed
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@Piinks @camsim99
Expose padding on RawScrollbar (flutter#107756)
4d2837d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xu-baolin xu-baolin xu-baolin approved these changes

Assignees

No one assigned

Labels

a: quality A truly polished experience autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Piinks @xu-baolin