Skip to content

Dart registrant location#107967

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
chingjun:dart_registrant_location
Jul 20, 2022
Merged

Dart registrant location#107967
auto-submit[bot] merged 3 commits intoflutter:masterfrom
chingjun:dart_registrant_location

Conversation

@chingjun
Copy link
Contributor

@chingjun chingjun commented Jul 19, 2022

This relands #107617, with additional fix that fixes #107845.

The fix is placed in a separate commit in this PR for easier review.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 19, 2022
christopherfujino
christopherfujino reviewed Jul 19, 2022
View reviewed changes
packages/flutter_tools/lib/src/compile.dart
: null;

String? dartPluginRegistrantUri;
if (dartPluginRegistrant != null && dartPluginRegistrant.existsSync()) {
Copy link
Contributor

@christopherfujino christopherfujino Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean if dartPluginRegistrant != null but it doesn't exist?

Copy link
Contributor Author

@chingjun chingjun Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm following the original code path actually.

Basically the dartPluginRegistrant is never null because it's hardcoded in FlutterProject to point to a specific file.

But the build system can skip the generation of this file. (https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/build_system/targets/dart_plugin_registrant.dart#L58)

Copy link
Contributor

@christopherfujino christopherfujino Jul 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, thanks

christopherfujino
christopherfujino approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingjun chingjun added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Jul 19, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 19, 2022

  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chingjun chingjun added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2022
@auto-submit auto-submit bot merged commit 922eea8 into flutter:master Jul 20, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
b6003b9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
51a7b40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
8f100fc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
c3bf315
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
6afe617
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
f9f7dea
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
7a957df
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
14c1490
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
764ab2c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
ca536e2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
2029073
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
bf4b644
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
c75af55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
0bb2344
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 22, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
1cc7f04
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
265c203
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
da2e108
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
25e8b64
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
5e4ba7d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
b59103a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
06cc575
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
93c53fd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
12bbe4a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
df64bec
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
9ba4849
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
eba0ab5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
6ae7bac
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
2531313
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
23469e2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
8d28a7e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
fbbf9d0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
d48c6ab
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
95bbac1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
c0ad403
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
30a40fa
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
43400d3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
922eea8 Dart registrant location (flutter/flutter#107967)
8d6fb51
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@chingjun @camsim99
Dart registrant location (flutter#107967)
014fac2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression in hotReloadDevFSSyncMilliseconds

2 participants

@chingjun @christopherfujino