Skip to content

make ModalBottomSheetRoute public#108112

Merged
auto-submit[bot] merged 37 commits intoflutter:masterfrom
The-Redhat:master
Oct 13, 2022
Merged

make ModalBottomSheetRoute public#108112
auto-submit[bot] merged 37 commits intoflutter:masterfrom
The-Redhat:master

Conversation

@The-Redhat
Copy link
Contributor

@The-Redhat The-Redhat commented Jul 21, 2022 •
edited
Loading

Currently it is not possible to use the ModalBottomSheetRoute in named routes (f.e. in the auto_route package) because it is private. In contrast the DialogRoute is public and therefore can be used.

This PR makes the ModalBottomSheetRoute public.

Related Issues

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 21, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jul 21, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@The-Redhat
Copy link
Contributor Author

The-Redhat commented Jul 21, 2022

Hey @stuartmorgan I'm not sure whom to tag / ask for review. Can you please help me out.

@goderbauer
Copy link
Member

goderbauer commented Jul 22, 2022

fly-by comment: @The-Redhat can you please take a look at the failing analyzer check and fix the reported issue? Also, please address the issue of missing tests (see comment by flutter-dashboard) before asking for review.

@HansMuller HansMuller requested a review from chunhtai July 22, 2022 21:42
@The-Redhat
Copy link
Contributor Author

The-Redhat commented Jul 23, 2022

Hey @HansMuller and @chunhtai can you please guide me on how a test for this change can look like.
Thank you for your help and have a great weekend.

chunhtai
chunhtai reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To write a test, you can use normal Navigator.push to open the modal bottom sheet and verify it opens as expected. You also want to verify the parameter works too.

@The-Redhat
Copy link
Contributor Author

The-Redhat commented Aug 10, 2022 •
edited
Loading

everything fixed. @chunhtai can you please review the mr

@The-Redhat
Copy link
Contributor Author

The-Redhat commented Aug 29, 2022

Hey @chunhtai is there something I have to do on my end?

@chunhtai chunhtai self-requested a review August 29, 2022 15:43
chunhtai
chunhtai reviewed Sep 15, 2022
View reviewed changes
chunhtai
chunhtai reviewed Sep 15, 2022
View reviewed changes
@The-Redhat
Copy link
Contributor Author

The-Redhat commented Sep 21, 2022

@chunhtai everything is fixed now :)

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 21, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 21, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 21, 2022

auto label is removed for flutter/flutter, pr: 108112, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 21, 2022

auto label is removed for flutter/flutter, pr: 108112, due to Validations Fail.

@chunhtai chunhtai requested a review from goderbauer September 21, 2022 20:24
@chunhtai
Copy link
Contributor

chunhtai commented Sep 21, 2022

cc @goderbauer for a secondary review

@The-Redhat
Copy link
Contributor Author

The-Redhat commented Oct 1, 2022

@goderbauer do you have some time to check this PR?

@gliitterpuke
Copy link

gliitterpuke commented Oct 8, 2022

would love to see this! eta until merge?

goderbauer
goderbauer reviewed Oct 10, 2022
View reviewed changes
@The-Redhat
Copy link
Contributor Author

The-Redhat commented Oct 11, 2022

Hey @goderbauer I took care of your review comments

@ryzizub
Copy link

ryzizub commented Oct 12, 2022

Would love to see this merged 🚀

goderbauer
goderbauer approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 13, 2022
@auto-submit auto-submit bot merged commit 274435d into flutter:master Oct 13, 2022
This was referenced Oct 14, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 14, 2022
@engine-flutter-autoroll
274435d make ModalBottomSheetRoute public (flutter/flutter#108112)
7bf3a5c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 14, 2022
@engine-flutter-autoroll
274435d make ModalBottomSheetRoute public (flutter/flutter#108112)
7380644
@jamesblasco
Copy link
Contributor

jamesblasco commented Nov 4, 2022 •
edited
Loading

This PR breaks the https://pub.dev/packages/modal_bottom_sheet package as it contains the same class. From the public available information this package is used in 12k open source projects hosted in github.

It would be great if we can come up with a solution before it gets out of hand in the packages repo:
jamesblasco/modal_bottom_sheet#284

@saltedpotatos saltedpotatos mentioned this pull request Dec 21, 2022
Closed
@saltedpotatos saltedpotatos mentioned this pull request Jan 26, 2023
Closed
@The-Redhat The-Redhat mentioned this pull request Sep 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@The-Redhat @goderbauer @chunhtai @gliitterpuke @ryzizub @jamesblasco