[flutter_tools] Remove unused parameter when connecting DAP to VM Service by DanTup · Pull Request #108285 · flutter/flutter

DanTup · 2022-07-25T11:36:08Z

This resumeIfStarting flag is passed to the base DAP implementation (which comes from the Dart SDK via DDS). Since dart-lang/sdk@02d9c3e the flag does absolutely nothing in the base class so this change is a no-op. The behaviour the flag previously controlled is now automatic and doesn't need an explicit flag.

The flag will be removed from the Dart SDK in the future after Flutter is no longer using it.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Since dart-lang/sdk@02d9c3e this flag does absolutely nothing. The behaviour it controlled is now automatic and the flag is not required. The flag will be removed from the Dart SDK in the future after Flutter is no longer using it.

flutter-dashboard · 2022-07-25T11:36:11Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Hixie · 2022-07-25T15:59:03Z

test-exempt: removing code

christopherfujino

LGTM

… VM Service (flutter/flutter#108285)

* 2142b2e Roll Flutter Engine from cd7e2ec4037b to c31036f2381c (1 revision) (flutter/flutter#108299) * 178e444 Revert "Add optional flag to determine assertiveness level in aria announcement for flutter web" (flutter/flutter#108262) * 8a7b359 flutter update-packages --force-upgrade + analyzer fix (flutter/flutter#108198) * b3f5d3f Roll Flutter Engine from c31036f2381c to 54b0ac3059bf (1 revision) (flutter/flutter#108302) * 2f4299a [flutter_tools] Remove unused parameter when connected DAP to VM Service (flutter/flutter#108285) * e74b9b5 Migrate InputDecorator to Material 3 (flutter/flutter#107943) * e3b851a Fix Tamil DateTime representation of AM/PM (flutter/flutter#108185) * 43d6e2b Roll Flutter Engine from 54b0ac3059bf to 705072522c00 (4 revisions) (flutter/flutter#108308) * 6929ad1 Roll Flutter Engine from 705072522c00 to 3964cf62cdf8 (1 revision) (flutter/flutter#108316) * 5f67b47 [iOS] Update template icons (flutter/flutter#107873) * 606954d Added iconSize parameter in ButtonStyle (flutter/flutter#108268) * b3814c7 Roll Flutter Engine from 3964cf62cdf8 to 7f8925b1f6f3 (2 revisions) (flutter/flutter#108320) * ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (flutter/flutter#108197) * d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (flutter/flutter#108349) * 4056d3f Explain the "patching" protocol in `KeyMessageManager.keyMessageHandler` and add an example (flutter/flutter#105280) * b035ef1 [flutter_tools] Remove more shuffles (flutter/flutter#107759) * be14858 Roll Flutter Engine from 7f8925b1f6f3 to 8eca26d130a2 (1 revision) (flutter/flutter#108326) * 3eb638f Roll Flutter Engine from 8eca26d130a2 to f1f9b4de82b6 (5 revisions) (flutter/flutter#108350) * 401b556 Roll Flutter Engine from f1f9b4de82b6 to 11d927ac3e9b (2 revisions) (flutter/flutter#108353) * 925bee9 Roll Flutter Engine from 11d927ac3e9b to 5dcaeae6561b (1 revision) (flutter/flutter#108356) * 5d31b07 [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (flutter/flutter#108310) * c8b5d10 Roll Flutter Engine from 5dcaeae6561b to 89e117b89c63 (1 revision) (flutter/flutter#108367) * e3d08fb Hide the debug banner in the PopupMenuButton example (flutter/flutter#108324)

…ice (flutter#108285) Since dart-lang/sdk@02d9c3e this flag does absolutely nothing. The behaviour it controlled is now automatic and the flag is not required. The flag will be removed from the Dart SDK in the future after Flutter is no longer using it.

* 2142b2e Roll Flutter Engine from cd7e2ec4037b to c31036f2381c (1 revision) (flutter/flutter#108299) * 178e444 Revert "Add optional flag to determine assertiveness level in aria announcement for flutter web" (flutter/flutter#108262) * 8a7b359 flutter update-packages --force-upgrade + analyzer fix (flutter/flutter#108198) * b3f5d3f Roll Flutter Engine from c31036f2381c to 54b0ac3059bf (1 revision) (flutter/flutter#108302) * 2f4299a [flutter_tools] Remove unused parameter when connected DAP to VM Service (flutter/flutter#108285) * e74b9b5 Migrate InputDecorator to Material 3 (flutter/flutter#107943) * e3b851a Fix Tamil DateTime representation of AM/PM (flutter/flutter#108185) * 43d6e2b Roll Flutter Engine from 54b0ac3059bf to 705072522c00 (4 revisions) (flutter/flutter#108308) * 6929ad1 Roll Flutter Engine from 705072522c00 to 3964cf62cdf8 (1 revision) (flutter/flutter#108316) * 5f67b47 [iOS] Update template icons (flutter/flutter#107873) * 606954d Added iconSize parameter in ButtonStyle (flutter/flutter#108268) * b3814c7 Roll Flutter Engine from 3964cf62cdf8 to 7f8925b1f6f3 (2 revisions) (flutter/flutter#108320) * ca6cecf Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (flutter/flutter#108197) * d155bc1 Revert "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate examples/tests (#108197)" (flutter/flutter#108349) * 4056d3f Explain the "patching" protocol in `KeyMessageManager.keyMessageHandler` and add an example (flutter/flutter#105280) * b035ef1 [flutter_tools] Remove more shuffles (flutter/flutter#107759) * be14858 Roll Flutter Engine from 7f8925b1f6f3 to 8eca26d130a2 (1 revision) (flutter/flutter#108326) * 3eb638f Roll Flutter Engine from 8eca26d130a2 to f1f9b4de82b6 (5 revisions) (flutter/flutter#108350) * 401b556 Roll Flutter Engine from f1f9b4de82b6 to 11d927ac3e9b (2 revisions) (flutter/flutter#108353) * 925bee9 Roll Flutter Engine from 11d927ac3e9b to 5dcaeae6561b (1 revision) (flutter/flutter#108356) * 5d31b07 [flutter_tools] [dap] Ensure DAP sends app.stop/app.detach during terminate (flutter/flutter#108310) * c8b5d10 Roll Flutter Engine from 5dcaeae6561b to 89e117b89c63 (1 revision) (flutter/flutter#108367) * e3d08fb Hide the debug banner in the PopupMenuButton example (flutter/flutter#108324)

DanTup requested a review from christopherfujino July 25, 2022 11:36

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 25, 2022

DanTup changed the title ~~[flutter_tools] Remove unused parameter when connected DAP to VM Service~~ [flutter_tools] Remove unused parameter when connecting DAP to VM Service Jul 25, 2022

christopherfujino approved these changes Jul 25, 2022

View reviewed changes

DanTup merged commit 2f4299a into flutter:master Jul 25, 2022

DanTup deleted the remove-resumeIfStarting branch July 25, 2022 17:28

engine-flutter-autoroll mentioned this pull request Jul 25, 2022

Roll Flutter from bbec650b64bc to 2f4299ad354d (179 revisions) flutter/packages#2375

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

2f4299a [flutter_tools] Remove unused parameter when connected DAP to…

58aad69

… VM Service (flutter/flutter#108285)

engine-flutter-autoroll mentioned this pull request Jul 25, 2022

Roll Flutter from bbec650b64bc to e74b9b5bef46 (180 revisions) flutter/packages#2376

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

2f4299a [flutter_tools] Remove unused parameter when connected DAP to…

1350664

… VM Service (flutter/flutter#108285)

engine-flutter-autoroll mentioned this pull request Jul 25, 2022

Roll Flutter from bbec650b64bc to e3b851a63413 (181 revisions) flutter/packages#2378

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

2f4299a [flutter_tools] Remove unused parameter when connected DAP to…

cf1f94d

… VM Service (flutter/flutter#108285)

engine-flutter-autoroll mentioned this pull request Jul 25, 2022

Roll Flutter from bbec650b64bc to 43d6e2b11385 (182 revisions) flutter/packages#2379

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

2f4299a [flutter_tools] Remove unused parameter when connected DAP to…

a06e0f2

… VM Service (flutter/flutter#108285)

This was referenced Jul 26, 2022

Roll Flutter from fa39206a2a34 to e3d08fb6d325 (23 revisions) flutter/plugins#6147

Merged

Roll Flutter from bbec650b64bc to e3d08fb6d325 (197 revisions) flutter/packages#2383

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 26, 2022

2f4299a [flutter_tools] Remove unused parameter when connected DAP to…

77d69d8

… VM Service (flutter/flutter#108285)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

2f4299a [flutter_tools] Remove unused parameter when connected DAP to…

6a5f61c

… VM Service (flutter/flutter#108285)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to 2f551d30086a (198 revisions) flutter/packages#2384

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

2f4299a [flutter_tools] Remove unused parameter when connected DAP to…

331d67b

… VM Service (flutter/flutter#108285)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to 527ee1d7286e (199 revisions) flutter/packages#2387

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

2f4299a [flutter_tools] Remove unused parameter when connected DAP to…

7b74b1c

… VM Service (flutter/flutter#108285)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to 87938cec4426 (200 revisions) flutter/packages#2389

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

2f4299a [flutter_tools] Remove unused parameter when connected DAP to…

ea1c228

… VM Service (flutter/flutter#108285)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to e05ae3cac799 (202 revisions) flutter/packages#2390

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

2f4299a [flutter_tools] Remove unused parameter when connected DAP to…

6c5216f

… VM Service (flutter/flutter#108285)

engine-flutter-autoroll mentioned this pull request Jul 26, 2022

Roll Flutter from bbec650b64bc to fe16c206ea19 (203 revisions) flutter/packages#2391

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

2f4299a [flutter_tools] Remove unused parameter when connected DAP to…

abd4b11

… VM Service (flutter/flutter#108285)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flutter_tools] Remove unused parameter when connecting DAP to VM Service#108285

[flutter_tools] Remove unused parameter when connecting DAP to VM Service#108285
DanTup merged 1 commit intoflutter:masterfrom
DanTup:remove-resumeIfStarting

DanTup commented Jul 25, 2022

Uh oh!

flutter-dashboard bot commented Jul 25, 2022

Uh oh!

Hixie commented Jul 25, 2022

Uh oh!

christopherfujino left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

DanTup commented Jul 25, 2022

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jul 25, 2022

Uh oh!

Hixie commented Jul 25, 2022

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants