Add shadowColor and surfaceTintColor to Dialog and DialogTheme.#108405
Merged
darrenaustin merged 3 commits intoflutter:masterfrom Jul 28, 2022
darrenaustin:dialog_shadow_color
Merged
Add shadowColor and surfaceTintColor to Dialog and DialogTheme.#108405darrenaustin merged 3 commits intoflutter:masterfrom darrenaustin:dialog_shadow_color
darrenaustin merged 3 commits intoflutter:masterfrom
darrenaustin:dialog_shadow_color
Conversation
guidezpl
requested changes
Jul 27, 2022
guidezpl
approved these changes
Jul 28, 2022
Member
guidezpl
left a comment
There was a problem hiding this comment.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is no way to configure the drop shadow and/or the surface tint overlay color used by dialogs. This PR adds exposes for the
shadowColorandsurfaceTintColorused byDialog's underlyingMaterialwidget. It also adds these properties toDialogThemeso they can be configured using themes.Fixes: #107423
Pre-launch Checklist
///).