Guard against usage after async callbacks in RenderAndroidView, unregister listener#108496
Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom Jul 28, 2022
Merged
Guard against usage after async callbacks in RenderAndroidView, unregister listener#108496auto-submit[bot] merged 3 commits intoflutter:masterfrom
auto-submit[bot] merged 3 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
framework
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Looks like a mock in another test needs updating, but otherwise LGTM. Thanks for investigating this!
We should definitely cherry-pick this to beta (and maybe even stable?).
stuartmorgan-g
approved these changes
Jul 28, 2022
dnfield
added
the
autosubmit
Contributor
|
auto-submit
bot
removed
the
autosubmit
Contributor
Author
|
Is the flutter_plugins failure a known issue? Looks like mockito deprecated something that plugins is using? |
Member
/cc @Piinks Is this the same issue that turned the tree red? |
Contributor
|
Yeah it is the same failure that has the tree red |
dnfield
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 29, 2022
…w, unregister listener (flutter/flutter#108496)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2022
…w, unregister listener (flutter/flutter#108496)
godofredoc
added a commit
that referenced
this pull request
Aug 2, 2022
…108831) * Guard against usage after async callbacks in RenderAndroidView, unregister listener (#108496) * Roll flutter/plugins (#108556) Co-authored-by: Dan Field <[email protected]> Co-authored-by: stuartmorgan <[email protected]>
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref b/186978412
When this code was written, render object disposal wasn't a thing. When I implemented that, I didn't realize there were async methods being used in this render object.
The test in this patch is basically a clone of an existing test, but it disposes the RO before completing some of the async operations. Without the changes in the implementation the test fails.