Skip to content

Fix an issue that semantics on TextField is not updated when changing obscureText#108545

Merged
auto-submit[bot] merged 157 commits intoflutter:masterfrom
hannah-hyj:semantic-obscureText
Aug 4, 2022
Merged

Fix an issue that semantics on TextField is not updated when changing obscureText#108545
auto-submit[bot] merged 157 commits intoflutter:masterfrom
hannah-hyj:semantic-obscureText

Conversation

@hannah-hyj
Copy link
Member

@hannah-hyj hannah-hyj commented Jul 28, 2022 •
edited
Loading

fixed: #99763

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 28, 2022
@hannah-hyj hannah-hyj changed the title Update editable.dart Fix an issue that semantics on TextField is not updated when changing obscureText Jul 28, 2022
@hannah-hyj hannah-hyj requested a review from chunhtai July 28, 2022 14:57
chunhtai
chunhtai reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but we need a test to make sure it does not regress.

engine-flutter-autoroll and others added 25 commits July 28, 2022 16:04
@engine-flutter-autoroll
Roll Flutter Engine from 41f8c14 to fca36b1 (1 revision) (flutter#108548
573bd3a 
)
@QuncCccccc
Change default value of effectiveInactivePressedOverlayColor in Swi…
8a8ed75 
…tch to refer to `effectiveInactiveThumbColor` (flutter#108477)
@goderbauer
Unify analysis options (flutter#108462)
10a7c9b
@stuartmorgan-g
Roll flutter/plugins (flutter#108556)
8d3ef0a
@engine-flutter-autoroll
Roll Flutter Engine from fca36b1 to bbd18cb (3 revisions) (flutter#10…
b188148 
…8559)
@dnfield
Guard against usage after async callbacks in RenderAndroidView, unreg…
0cc7db5 
…ister listener (flutter#108496)
@engine-flutter-autoroll
Roll Flutter Engine from bbd18cb to 9b278ae (3 revisions) (flutter#10…
058d272 
…8564)
disable new transition while toPictureSync is fixed (flutter#108565)
6cb2f5d
@engine-flutter-autoroll
Roll Flutter Engine from 9b278ae to 4019c8d (1 revision) (flutter#108572
af1428a 
)
@engine-flutter-autoroll
Roll Flutter Engine from 4019c8d to 0a547b3 (1 revision) (flutter#108575
8e77cb4 
)
@goderbauer
Mark NavigationBar as non-const to match reality (flutter#108562)
d10a4a1
@engine-flutter-autoroll
Roll Flutter Engine from 0a547b3 to 879efec (2 revisions) (flutter#10…
381f584 
…8578)
@darrenaustin
Add shadowColor and surfaceTintColor to Dialog and DialogTheme. (flut…
523b600 
…ter#108405)
@dependabot
Bump github/codeql-action from 2.1.16 to 2.1.17 (flutter#108580)
df8bead
@fluttergithubbot
Roll pub packages (flutter#108465)
d0cab09
@engine-flutter-autoroll
Roll Flutter Engine from 879efec to f669cfb (2 revisions) (flutter#10…
3079326 
…8581)
@engine-flutter-autoroll
Roll Flutter Engine from f669cfb to 9624d86 (2 revisions) (flutter#10…
3cdb91f 
…8583)
@hellohuanlin
[platform_view]add android deps to platform view test (flutter#108585)
b00bfef
@yusuf-goog
Remove failing test Linux_android android_lifecycles_test. (flutter#1…
4aa3d74 
…08587)
@engine-flutter-autoroll
Roll Flutter Engine from 9624d86 to 862773f (1 revision) (flutter#108589
304aae3 
)
@engine-flutter-autoroll
Roll Flutter Engine from 862773f to 0113223 (1 revision) (flutter#108591
b6e9260 
)
@GaryQian
Reland "Upgrade Gradle and AGP versions to 7.5/7.2 and migrate benchm…
7cfbdad 
…arks+examples" flutter#108472 (flutter#108510)
@GaryQian
Remove doc for --ignore-deprecation and check for pubspec before v1 e…
762c92e 
…mbedding check (flutter#108523)
@engine-flutter-autoroll
Roll Flutter Engine from 0113223 to 260d979 (1 revision) (flutter#108592
bcb973e 
)
@engine-flutter-autoroll
Roll Flutter Engine from 260d979 to 5080fd6 (1 revision) (flutter#108596
8da73f7 
)
@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2022
@auto-submit auto-submit bot merged commit f5cecd0 into flutter:master Aug 4, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 4, 2022
@engine-flutter-autoroll
f5cecd0 Fix an issue that semantics on TextField is not updated when …
8f45524 
…changing obscureText (flutter/flutter#108545)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 4, 2022
@engine-flutter-autoroll
f5cecd0 Fix an issue that semantics on TextField is not updated when …
942daa3 
…changing obscureText (flutter/flutter#108545)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 4, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 4, 2022
@engine-flutter-autoroll
f5cecd0 Fix an issue that semantics on TextField is not updated when …
c9849c1 
…changing obscureText (flutter/flutter#108545)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@hannah-hyj @camsim99
Fix an issue that semantics on TextField is not updated when changing…
fced611 
… obscureText (flutter#108545)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Android]Semantics on TextField is not updated when changing obscureText to false