disable new transition while toPictureSync is fixed#108565
disable new transition while toPictureSync is fixed#108565auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Waiting to see what tests fail... |
dnfield
left a comment
There was a problem hiding this comment.
LGTM assuming tests pass.
|
Test updated |
|
This caused an expected regression in |
Yes - we're losing the benefits we had gained from this change, but for now we need to because the API has a race condition in it that can cause crashes, which I'm working on fixing. |
This reverts commit 6cb2f5d.
Reverts default usage of toPictureSync while we work through #108389