[platform_view]run platform view ui test to physical device#108642
[platform_view]run platform view ui test to physical device#108642auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
keyonghan
left a comment
There was a problem hiding this comment.
https://cs.opensource.google/flutter/flutter/+/master:TESTOWNERS;l=201 should be moved under section: ## Mac iOS DeviceLab tests
This change request is for TESTOWNERS file. |
3c56bd4 to
7d29046
Compare
Oh sorry i misunderstood. Updated both to be consistent. |
The failure is because
await devices.workingDevicerequires a physical device, and we were running it usingMacname under.ci.yaml.There are 3 possible fixes:
testWithNewIOSSimulatorto get the device ID, and run the simulator. In this case we don't have to setdeviceOperatingSystembecause it's only for physical device.flutter_dronetest which runs on simulator too, but it is a lot more involved (moving the test fromdevicelabtoflutter_drone).We pick option 2 because it's relatively easier, and we may actually want to test platform views on device (e.g. measure performance, etc).
List which issues are fixed by this PR. You must list at least one issue.
#106745 (comment)
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.