Skip to content

Fix CupertinoListTile`s onTap with delay throws exception#109038

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
NevercodeHQ:fix_cupertino_list_tile_exception
Aug 16, 2022
Merged

Fix CupertinoListTile`s onTap with delay throws exception#109038
auto-submit[bot] merged 1 commit intoflutter:masterfrom
NevercodeHQ:fix_cupertino_list_tile_exception

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented Aug 5, 2022

fixes #109024

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Aug 5, 2022
@TahaTesser TahaTesser changed the title Fix CupertinoListTiles onTap with delay throws exception Fix CupertinoListTile\`s onTap with delay throws exception Aug 5, 2022
@TahaTesser TahaTesser changed the title Fix CupertinoListTile\`s onTap with delay throws exception Fix CupertinoListTile`s onTap with delay throws exception Aug 5, 2022
@TahaTesser TahaTesser requested a review from gspencergoog August 5, 2022 13:29
gspencergoog
gspencergoog approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@TahaTesser TahaTesser force-pushed the fix_cupertino_list_tile_exception branch from 410904f to b76461d Compare August 16, 2022 08:26
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2022
@auto-submit auto-submit bot merged commit f4a64ef into flutter:master Aug 16, 2022
@TahaTesser TahaTesser deleted the fix_cupertino_list_tile_exception branch August 16, 2022 10:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2022
@engine-flutter-autoroll
f4a64ef Fix CupertinoListTile`s onTap with delay throws exception (f…
20e354c 
…lutter/flutter#109038)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 17, 2022
@engine-flutter-autoroll
f4a64ef Fix CupertinoListTile`s onTap with delay throws exception (f…
5219c1d 
…lutter/flutter#109038)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CupertinoListTile is missing mounted checks

2 participants

@TahaTesser @gspencergoog