Conversation
flutter-dashboard
bot
added
f: material design
|
It'd be great if someone on the team could elaborate what the failed tests show, from what I can see there's no information about why those test failed |
|
It seems like the tests failed to compile, not sure about why but doesnt look related to this PR, would be great if someone could suggest how this can be resolved |
Hari-07
force-pushed
the
strokecap-progress-indicator
branch
from
95fde0f to
b0aad0c
Compare
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
We appreciate the contribution but do not have the bandwidth to help debug the test failures (#109111 (comment)). If you're unable to sort the failures out, please close the PR, at least for now. Sorry we couldn't be of more help.
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| /// The Progress Indicator's line endings | ||
| /// | ||
| /// Defaults to [StrokeCap.square] | ||
| final StrokeCap strokeCap; |
There was a problem hiding this comment.
Is this for the value? Or the track? It may be beneficial to add both options where relevant, like the linear indicator.
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Can this also be added to the corresponding themes when the new PR is staged? :)
|
Also for consideration, should this be handled with StrokeCap? Or with a radius parameter? I think of how we do this with Slider and Scrollbar.. folks like to customize the curvature |
|
I could possibly work on this, but... hmm... this is tricky with radius. If you know how to solve, I can make a PR:
|
I don't right now, but @Hari-07 mentioned they could reopen a new PR. Thanks @bernaferrari! |
4 participants
Adds a
StrokeCapparameter on theProgressIndicatorclass with a default value ofStrokeCap.square, and also gives access to this parameter viaCircularProgressIndicatorandRefreshProgressIndicatorList which issues are fixed by this PR. You must list at least one issue.
#109137
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Non-breaking change: Added the strokecap property on arc painter
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.