replace engine and framework mirror args with github username arg#109239
replace engine and framework mirror args with github username arg#109239auto-submit[bot] merged 5 commits intoflutter:masterfrom itsjustkevin:replace-mirror-args
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
|
this is fine as long as you're willing to accept the constraint that it will only ever work with a project name that matches the name of the canonical upstreams. |
|
@christopherfujino do you feel that this solution isn't generic enough? I am looking at this from the perspective of the people currently using the release tooling, but I can absolutely see where this could be an issue down the line if we decide to make changes. |
| argumentResults, | ||
| platform.environment, | ||
| )!; | ||
| final String engineMirror = 'https://github.com/$githubUsername/engine.git'; |
There was a problem hiding this comment.
What if we share a common available GitHub account?
There was a problem hiding this comment.
If that is the case, we could hardcode the mirrors and remove the argument completely. Do you see another approach I could take here?
There was a problem hiding this comment.
Looking at this comment again: What if the release team did share a common github account? We would probably still want some kind of mechanism to verify who is doing what under that shared account.
Will look further into this.
There was a problem hiding this comment.
Exactly :-)
We could see if https://github.com/fluttergithubbot is ok to be used. We may need to lock it down so not all maintainers are able to contribute to the forks.
As a power user, I've definitely used the conductor on secondary/tertiary forks. It doesn't happen often, though. |
Thanks for pointing this out, I have not considered this use case. Open for suggestions. |
christopherfujino
left a comment
christopherfujino
left a comment
There was a problem hiding this comment.
Generally, most of the dart format changes here are against the repo's style guide: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#formatting
Do you have a VSCode settings.json file I could use to avoid this in the future? It would be nice if there was one available, there may be one already somewhere. |
It's trivial to globally disable autoformat on an editor level (https://linuxpip.org/vscode-format-on-save/#:~:text=Save%20not%20working-,Enable%2FDisable%20Format%20On%20Save,click%20on%20the%20right%20option.). I'm sure you could also do this on a language level for all Dart source files, but I'm not sure how to do it on a per-repo level (not sure if you submit patches to flutter/cocoon). |
Will update after reading the style guide fully. |
itsjustkevin
added
the
autosubmit
3 participants
Remove the
--framework-mirrorand--engine-mirrorargs and replace them with the--github-usernamearg which interpolates the username into the framework and engine mirror urls.