Copy doc files from new to old location.#109316
Copy doc files from new to old location.#109316auto-submit[bot] merged 2 commits intoflutter:masterfrom godofredoc:fix_docs
Conversation
Changes to the objectc docs to make destination paths consistent cause failures in the documentation scripts becase some of the files could not be found anymore. This change copies files to the old location if it identifies the new location exist. Bug: #109229
flutter-dashboard
bot
added
the
c: contributor-productivity
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is needed to reland flutter/engine#35265 |
| } | ||
| } | ||
|
|
||
| /// If object then copy files to old location if the archive is using the new location. |
There was a problem hiding this comment.
can you give me some context on why we have a new and old location? are the contents different?
There was a problem hiding this comment.
The contents are the same but the folder structure added an objectc_docs folder and puts all the contents there.
The context of that change is that with recipes v2 migration we are moving the generation of the zip files from the recipes to the engine and having the additional folder helps us prevent adding additional files to the zip if for some reason a nonempty directory is passed to the tools/gen_objcdoc.sh script.
After the migration to engine v2 is complete we can get rid of this additional complexity.
godofredoc
added
the
autosubmit
2 participants
Changes to the objectc docs to make destination paths consistent cause
failures in the documentation scripts becase some of the files could not
be found anymore. This change copies files to the old location if it
identifies the new location exist.
Bug: #109229
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.