Actually run customer_testing shard on Windows#109336
Actually run customer_testing shard on Windows#109336auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
c: contributor-productivity
|
test-exempt: is a test Though I wonder if there's some way we could adjust the logic in the recipes to verify that we're not unintentionally using this windows "feature" since it's quite possible it's going to bite us again... |
Hixie
force-pushed
the
customer_testing
branch
4 times, most recently
from
4e0a21c to
6683921
Compare
When `dart` became a batch file, the semantics changed because on Windows calling a batch file directly aborts the calling file. You have to use `CALL` to call a batch file from another.
Hixie
force-pushed
the
customer_testing
branch
from
6683921 to
d7bc2d7
Compare
|
Apparently Glob() doesn't like |
|
Are you saying these haven't run since we introduced the dart.bat file? |
Seems that way. |
|
Could this have caused the current build redness? It seems to have started when this merged. Sample failures: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_engine_group_performance/4230/overview |
|
Actually, it seems unlikely, since those failures are on Linux. |
3 participants
When
dartbecame a batch file, the semantics changed because on Windows calling a batch file directly aborts the calling file.You have to use
CALLto call a batch file from another.