Set IconButton.visualDensity default to VisualDensity.standard#109349
Merged
QuncCccccc merged 7 commits intoflutter:masterfrom Aug 11, 2022
Merged
Set IconButton.visualDensity default to VisualDensity.standard#109349QuncCccccc merged 7 commits intoflutter:masterfrom
IconButton.visualDensity default to VisualDensity.standard#109349QuncCccccc merged 7 commits intoflutter:masterfrom
Conversation
HansMuller
approved these changes
Aug 11, 2022
| /// a component theme parameter like [sliderTheme], [toggleButtonsTheme], | ||
| /// or [bottomNavigationBarTheme]. | ||
| /// | ||
| /// In Material Design 3, the [IconButton.visualDensity] isn't affected by |
Contributor
There was a problem hiding this comment.
I think this comment probably belongs with the visualDensity API doc.
QuncCccccc
added a commit
to QuncCccccc/flutter
that referenced
this pull request
Aug 12, 2022
…ity.standard` (flutter#109349)" (flutter#109421)" This reverts commit 625d96a.
8 tasks
This was referenced Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 13, 2022
This was referenced Aug 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 14, 2022
This was referenced Aug 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 15, 2022
QuncCccccc
added a commit
that referenced
this pull request
Aug 18, 2022
#109432) * Revert "Revert "Set `IconButton.visualDensity` default to `VisualDensity.standard` (#109349)" (#109421)" Co-authored-by: Qun Cheng <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #64702, so the


IconButtons on AppBar have a proper circular splash.This PR also sets the default
visualDensityof IconButton toVisualDensity.standard, to ensure the default IconButton will have a circular shape even if the app is running on desktop/web platforms (whose default compact visual density changes the shape to be rounded rectangle).Just for more information, the default

IconButtonhas a size of 48x48, 4 pixels of padding, and a circular shape. However, if a button changes to a different size or shape, the padding between buttons might be different from the default. The below code can achieve a combination of circular IconButton and rounded rectangle IconButton with the same paddings between each other, like the screenshot below.Details
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.