Skip to content

Added documentation for AppBar actions#109351

Merged
QuncCccccc merged 2 commits intoflutter:masterfrom
QuncCccccc:add_doc_for_app_bar_actions
Aug 11, 2022
Merged

Added documentation for AppBar actions#109351
QuncCccccc merged 2 commits intoflutter:masterfrom
QuncCccccc:add_doc_for_app_bar_actions

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Aug 10, 2022

This pr fixed #109331.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 10, 2022
@QuncCccccc QuncCccccc marked this pull request as ready for review August 10, 2022 23:28
@QuncCccccc QuncCccccc requested a review from HansMuller August 10, 2022 23:29
@QuncCccccc QuncCccccc force-pushed the add_doc_for_app_bar_actions branch from 1f919f2 to 28f846c Compare August 11, 2022 00:08
HansMuller
HansMuller approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/material/app_bar.dart Outdated
Copy link
Contributor

@HansMuller HansMuller Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid having the last action covered by the debug banner, you may want to set the ...

@QuncCccccc QuncCccccc force-pushed the add_doc_for_app_bar_actions branch from b4352d4 to ca891ba Compare August 11, 2022 18:39
@QuncCccccc QuncCccccc merged commit 1eb8712 into flutter:master Aug 11, 2022
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
1e94c9b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
0214b5a
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
449b9c9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
a2f7b63
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
17d0d02
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
ea540bc
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
6dc697c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
f4ac33a
This was referenced Aug 12, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
05fd4f9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
14d2138
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
8700de3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
b995fa9
This was referenced Aug 13, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
51a2c0a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
c62c2cc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
787750d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 13, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
dbdb81f
This was referenced Aug 14, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
762f50b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
b088b01
This was referenced Aug 14, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
9313d5f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
b0b2a06
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
d39154e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
e22f954
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
0b740d8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
a0cc0ab
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
2307042
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
7462c90
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
d699d9b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
034a7d9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
223838d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
@engine-flutter-autoroll
1eb8712 Added documentation for AppBar actions (flutter/flutter#109351)
39135b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AppBar actions API doc should warn about the debug banner obscuring the last action

2 participants

@QuncCccccc @HansMuller