Fix HTML in skeletons (ampersands must be escaped)#109360
Fix HTML in skeletons (ampersands must be escaped)#109360auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
Technically we should also be escaping the IDs and channel names and such but it's safe if we can guarantee they are always alphanumeric.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Not really sure how to test this... |
|
Well, you could maybe check for a valid link in sanityCheckDocs in |
|
I looked into what a sensible test would be but short of actually validating the HTML I don't think there's much point. I filed #109362 for that. I considered just duplicating the template into the sanityCheckDocs test but it already checks for the bulk of what matters, it just doesn't quite hit any of the ampersands, looking at the HTML spec in more detail, technically I don't think they actually have to be escaped most of the time anyway, it's just good practice. |
|
test-exempt: see above |
|
(Assuming you're ok with the fix, feel free to add the autosubmit label when reviewing.) |
|
I agree that there's not a lot to test here, really. |

Technically we should also be escaping the IDs and channel names and such but it's safe if we can guarantee they are always alphanumeric.