Reland: Fix Android platform view creation flow#109405
Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom Aug 12, 2022
Merged
Reland: Fix Android platform view creation flow#109405auto-submit[bot] merged 3 commits intoflutter:masterfrom
auto-submit[bot] merged 3 commits intoflutter:masterfrom
Conversation
)" This reverts commit 9ad052a.
dnfield
reviewed
Aug 11, 2022
dnfield
approved these changes
Aug 12, 2022
This was referenced Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 12, 2022
This was referenced Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 12, 2022
This was referenced Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 12, 2022
This was referenced Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 12, 2022
This was referenced Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2022
This was referenced Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 15, 2022
stuartmorgan-g
added a commit
to stuartmorgan-g/flutter
that referenced
this pull request
Aug 15, 2022
This was referenced Aug 15, 2022
This was referenced Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 15, 2022
This was referenced Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 15, 2022
This was referenced Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 15, 2022
CaseyHillers
pushed a commit
that referenced
this pull request
Aug 18, 2022
* update engine version * Reland: Fix Android platform view creation flow (#109405) Co-authored-by: itsjustkevin <[email protected]> Co-authored-by: Casey Hillers <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands #109232 with a fix for
google_mobile_adsThere was a subtle race in the previous version of the PR, which
google_mobile_adshit but the plugin I was testing with did not: because_sendCreateMessageis async, even if it returned false synchronously due tonullsize,createdidn't necessarily continue synchronously. This created a brief async gap for TLHC where the state wascreating, and thusawaitingCreationwould return false, and the secondcreatecall fromPlatformViewLinkwouldn't fire.This fixes that (see second commit in the PR) by using a synchronous getter rather than an async bool return value from the subclass to know whether to drop null-size calls to
create.Fixes (at least part of) #107297
Pre-launch Checklist
///).