Skip to content

Reland: Fix Android platform view creation flow#109405

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
stuartmorgan-g:android-platform-view-double-create-reland
Aug 12, 2022
Merged

Reland: Fix Android platform view creation flow#109405
auto-submit[bot] merged 3 commits intoflutter:masterfrom
stuartmorgan-g:android-platform-view-double-create-reland

Conversation

@stuartmorgan-g
Copy link
Contributor

Re-lands #109232 with a fix for google_mobile_ads

There was a subtle race in the previous version of the PR, which google_mobile_ads hit but the plugin I was testing with did not: because _sendCreateMessage is async, even if it returned false synchronously due to null size, create didn't necessarily continue synchronously. This created a brief async gap for TLHC where the state was creating, and thus awaitingCreation would return false, and the second create call from PlatformViewLink wouldn't fire.

This fixes that (see second commit in the PR) by using a synchronous getter rather than an async bool return value from the subclass to know whether to drop null-size calls to create.

Fixes (at least part of) #107297

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 11, 2022
@stuartmorgan-g stuartmorgan-g changed the title Android platform view double create reland Reland: Fix Android platform view creation flow Aug 11, 2022
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 12, 2022
@auto-submit auto-submit bot merged commit ab23233 into flutter:master Aug 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
stuartmorgan-g added a commit to stuartmorgan-g/flutter that referenced this pull request Aug 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 15, 2022
lin-erik added a commit that referenced this pull request Aug 15, 2022
CaseyHillers pushed a commit that referenced this pull request Aug 18, 2022
* update engine version

* Reland: Fix Android platform view creation flow (#109405)

Co-authored-by: itsjustkevin <[email protected]>
Co-authored-by: Casey Hillers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants