Skip to content

CP: Fix Android platform view creation flow#109544

Merged
CaseyHillers merged 3 commits intoflutter:flutter-3.2-candidate.5from
stuartmorgan-g:beta-cp-android-platform-view-double-create
Aug 18, 2022
Merged

CP: Fix Android platform view creation flow#109544
CaseyHillers merged 3 commits intoflutter:flutter-3.2-candidate.5from
stuartmorgan-g:beta-cp-android-platform-view-double-create

Conversation

@stuartmorgan-g
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g commented Aug 15, 2022

Cherry-pick #109405

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 15, 2022

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to cherrypicks-flutter-3.2-candidate.5. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from cherrypicks-flutter-3.2-candidate.5 to master August 15, 2022 15:25
@flutter-dashboard flutter-dashboard bot added engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 15, 2022
@stuartmorgan-g stuartmorgan-g mentioned this pull request Aug 15, 2022
Closed
CaseyHillers
CaseyHillers approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers CaseyHillers changed the base branch from master to flutter-3.2-candidate.4 August 18, 2022 07:09
@CaseyHillers CaseyHillers requested a review from Piinks as a code owner August 18, 2022 07:09
@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 18, 2022

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-3.2-candidate.4. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-3.2-candidate.4 to master August 18, 2022 07:09
@CaseyHillers CaseyHillers self-requested a review August 18, 2022 07:10
@CaseyHillers CaseyHillers changed the base branch from master to flutter-3.2-candidate.5 August 18, 2022 07:10
@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 18, 2022

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-3.2-candidate.5. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-3.2-candidate.5 to master August 18, 2022 07:10
@CaseyHillers CaseyHillers changed the base branch from master to flutter-3.2-candidate.5 August 18, 2022 07:11
@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Aug 18, 2022

@CaseyHillers Is there an issue tracking all the token errors in CI here?

@CaseyHillers
Copy link
Contributor

CaseyHillers commented Aug 18, 2022

@CaseyHillers Is there an issue tracking all the token errors in CI here?

No, but I'll send the follow up PR

@CaseyHillers CaseyHillers merged commit 7fba378 into flutter:flutter-3.2-candidate.5 Aug 18, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
7fba378 CP: Fix Android platform view creation flow (flutter/flutter#…
b23f738 
…109544)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
7fba37848 CP: Fix Android platform view creation flow (flutter/flutte…
b20fb5e 
…r#109544)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Awaiting requested review from Piinks

1 more reviewer

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stuartmorgan-g @CaseyHillers @itsjustkevin