Some changes needed to PlatformMenuBar before the MenuBar implementation change lands.#109556
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Aug 16, 2022
Merged
Conversation
flutter-dashboard
bot
added
d: api docs
gspencergoog
force-pushed
the
menu_bar_platform
branch
2 times, most recently
from
7233896 to
b7cb16a
Compare
…ion change lands.
gspencergoog
force-pushed
the
menu_bar_platform
branch
from
b7cb16a to
e8d65d7
Compare
goderbauer
approved these changes
Aug 16, 2022
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM assuming dropping MenuItem doesn't break any customer tests or google3.
gspencergoog
added
the
autosubmit
This was referenced Aug 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2022
…lementation change lands. (flutter/flutter#109556)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 17, 2022
…lementation change lands. (flutter/flutter#109556)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the connection between MenuBar (not yet committed) and the platform menu bar, by removing the
MenuItemclass, and replacing it withPlatformMenuItem.Related Issues
Tests