Re-land Add Spell Check to EditableText #109643
Merged
auto-submit[bot] merged 11 commits intoflutter:masterfrom Aug 17, 2022
Merged
Re-land Add Spell Check to EditableText #109643auto-submit[bot] merged 11 commits intoflutter:masterfrom
auto-submit[bot] merged 11 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
a: tests
Contributor
Author
|
@justinmc The fix for the failed test is here https://github.com/flutter/flutter/pull/109643/files#diff-1ae099567a7a5b9a2a2be57a54b37ee411f3bbd94cdcdbaf8692ec46c8c642cfR17-R22. |
justinmc
approved these changes
Aug 17, 2022
Contributor
There was a problem hiding this comment.
Reland LGTM 👍
I wonder why this docs analyzer error wasn't caught before merge last time?
Edit: I asked on Discord: https://discord.com/channels/608014603317936148/608021351567065092/1009491652395679886
camsim99
added
the
autosubmit
keyonghan
reviewed
Aug 17, 2022
| tags: > | ||
| ["devicelab", "android", "linux"] | ||
| task_name: spell_check_test | ||
| scheduler: luci |
Contributor
There was a problem hiding this comment.
Sorry I should have caught this earlier.
Now everything is with cocoon scheduling, and we should remove the scheduler: luci.
I created #109712 to track the doc update.
This was referenced Aug 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands #109334 with a fix for https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20analyze/8873/overview.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.