Introduce stubbed exclusive parameter to File.create-overridden method#109646
Introduce stubbed exclusive parameter to File.create-overridden method#109646aam merged 5 commits intoflutter:masterfrom
exclusive parameter to File.create-overridden method#109646Conversation
…ethod. This is to soften landing of a breaking change dart-lang/sdk#49647
flutter-dashboard
bot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
I added a simple test that verifies that |
|
|
||
| testWithoutContext('create accepts exclusive argument', () { | ||
| final FileSystem fileSystem = MemoryFileSystem.test(); | ||
| fileSystem.file('file').create(exclusive: true); |
There was a problem hiding this comment.
nit: this should have some kind of expectation in the test :)
…ridden method (flutter/flutter#109646)
…ridden method (flutter/flutter#109646)
2 participants
This is to soften landing of a breaking change dart-lang/sdk#49647