[macOS] Bring up "hello_world" devicelab, compilation test for x86. by a-wallen · Pull Request #109891 · flutter/flutter

a-wallen · 2022-08-19T22:32:56Z

Reason

The initial desktop integration tests are running now, but they need to be expanded beyond the initial gallery build test; filing this to make sure that planned work is captured in the issue tracker. This should be much more straightforward that getting the first one running was, since the bot work is all complete.

In particular we should ensure we are testing building a freshly created project to catch errors in template changes. (I haven't checked where that test lives on existing platforms; it may be a device lab test, which still needs desktop bring-up).

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

.ci.yaml

dev/devicelab/lib/tasks/perf_tests.dart

yaakovschectman

LGTM plus Chris' comment

dev/devicelab/lib/tasks/perf_tests.dart

.ci.yaml

a-wallen · 2022-08-23T03:26:02Z

Blocked until #110050 lands.

Add mac_arm64 host only platform support in .ci.yaml #110050

dev/devicelab/lib/tasks/perf_tests.dart

…arwinApp.

…for clarity, reusability

…d outputs

Resolved with a commit that was force pushed. Original review now marked as outdated.

jmagman

I wasn't done reviewing this, can you make a new PR to follow up?

jmagman · 2022-08-24T17:48:00Z

dev/devicelab/lib/tasks/perf_tests.dart

+              appPath: appBundlePath,
+              operatingSystem: deviceOperatingSystem,


Suggested change

appPath: appBundlePath,

operatingSystem: deviceOperatingSystem,

appPath: appBundlePath,

operatingSystem: deviceOperatingSystem,

jmagman · 2022-08-25T00:41:07Z

dev/devicelab/lib/tasks/perf_tests.dart

        // IPAs are created manually, https://flutter.dev/ios-release/
-        await exec('tar', <String>['-zcf', 'build/app.ipa', appPath]);
+        await exec('tar', <String>['-zcf', 'build/app.ipa', appBundlePath]);
        releaseSizeInBytes = await file('$cwd/build/app.ipa').length();


This comment doesn't make sense, ipa isn't a thing on macOS. How about:

// Validate changes in Dart snapshot format and data layout do not change compression size. await exec('tar', <String>['-zcf', 'build/app.tar.gz', appPath]); releaseSizeInBytes = await file('$cwd/build/app.tar.gz').length();

uh-oh sorry about that!

…r x86. (flutter/flutter#109891)

cbracken

🎉

…r x86. (flutter/flutter#109891)

a-wallen requested a review from keyonghan as a code owner August 19, 2022 22:32

flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 19, 2022

a-wallen requested review from XilaiZhang and cbracken August 19, 2022 22:33

a-wallen commented Aug 19, 2022

View reviewed changes

.ci.yaml Outdated Show resolved Hide resolved

a-wallen changed the title ~~[macOS] Bring Up "hello_world" {Release, Debug} Compile Tests for {Intel, ARM64~~ [macOS] Bring Up "hello_world" {Release, Debug} Compile Tests for {Intel, ARM64} Aug 19, 2022

a-wallen changed the title ~~[macOS] Bring Up "hello_world" {Release, Debug} Compile Tests for {Intel, ARM64}~~ [macOS] Bring Up "hello_world" {Release, Debug} Compile Tests for mac Aug 19, 2022

a-wallen force-pushed the macos_bringup_hello_compile branch 2 times, most recently from e175a32 to ce2c6fa Compare August 22, 2022 13:34

a-wallen changed the title ~~[macOS] Bring Up "hello_world" {Release, Debug} Compile Tests for mac~~ [macOS] Bring Up "hello_world" (Release, Debug) Compile Tests for mac Aug 22, 2022

a-wallen force-pushed the macos_bringup_hello_compile branch from ce2c6fa to c9a6eb2 Compare August 22, 2022 16:23

a-wallen marked this pull request as draft August 22, 2022 17:22

a-wallen force-pushed the macos_bringup_hello_compile branch 3 times, most recently from a81e0de to a2be933 Compare August 22, 2022 20:01

a-wallen marked this pull request as ready for review August 22, 2022 20:04

cbracken requested a review from yaakovschectman August 22, 2022 20:08

cbracken reviewed Aug 22, 2022

View reviewed changes

dev/devicelab/lib/tasks/perf_tests.dart Outdated Show resolved Hide resolved

yaakovschectman approved these changes Aug 22, 2022

View reviewed changes

a-wallen force-pushed the macos_bringup_hello_compile branch from a2be933 to a6c2e71 Compare August 22, 2022 20:25

jmagman previously requested changes Aug 22, 2022

View reviewed changes

dev/devicelab/lib/tasks/perf_tests.dart Outdated Show resolved Hide resolved

dev/devicelab/lib/tasks/perf_tests.dart Outdated Show resolved Hide resolved

cbracken reviewed Aug 22, 2022

View reviewed changes

dev/devicelab/lib/tasks/perf_tests.dart Outdated Show resolved Hide resolved

a-wallen force-pushed the macos_bringup_hello_compile branch from a6c2e71 to 0cff6be Compare August 23, 2022 00:14

keyonghan reviewed Aug 23, 2022

View reviewed changes

.ci.yaml Outdated Show resolved Hide resolved

a-wallen force-pushed the macos_bringup_hello_compile branch from d79e2d5 to d70df45 Compare August 23, 2022 03:34

a-wallen changed the title ~~[macOS] Bring Up "hello_world" (Release, Debug) Compile Tests for mac~~ [macOS] Bring up "hello_world" devicelab, compilation test for x86 and arm64. Aug 23, 2022

a-wallen force-pushed the macos_bringup_hello_compile branch from d70df45 to 1d3b6a1 Compare August 23, 2022 16:39

jmagman reviewed Aug 23, 2022

View reviewed changes

a-wallen force-pushed the macos_bringup_hello_compile branch from 1d3b6a1 to 988e20b Compare August 23, 2022 18:26

a-wallen force-pushed the macos_bringup_hello_compile branch 3 times, most recently from 33692c6 to 7a54ddc Compare August 24, 2022 00:23

Alex Wallen added 10 commits August 23, 2022 17:49

Implement application compilation (release) test for macos.

6ee8add

Implement application compilation (debug) test for macos.

c27297b

Register hello_world compile test for macos locally.

52d3bf2

Bring up macos hello_world compile test for mac x86

eebdb74

claim ownership of hello_world_macos__compile.dart in TESTOWNERS

0014b30

Refactor getSizesFromIosApp to include macos. Rename to getSizesFromD…

28270cf

…arwinApp.

Prefer Object over dynamic in getSizesFromDarwinApp

43549bc

Rename _findIosAppInBuildDirectory to _findDarwinAppInBuildDirectory …

4cfeaff

…for clarity, reusability

Refactor _findDarwinAppInBuildDirectory logic to work for darwin buil…

7ad7986

…d outputs

Merge logic for ios and macos into one branch in _compileApp()

5c1b21c

a-wallen force-pushed the macos_bringup_hello_compile branch from 7a54ddc to 5c1b21c Compare August 24, 2022 00:50

a-wallen requested a review from jmagman August 24, 2022 17:20

a-wallen added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2022

a-wallen changed the title ~~[macOS] Bring up "hello_world" devicelab, compilation test for x86 and arm64.~~ [macOS] Bring up "hello_world" devicelab, compilation test for x86. Aug 24, 2022

auto-submit bot merged commit d71a8a7 into flutter:master Aug 24, 2022

jmagman reviewed Aug 25, 2022

View reviewed changes

engine-flutter-autoroll mentioned this pull request Aug 25, 2022

Roll Flutter from 360ac5bc79aa to da09f78ecb44 (27 revisions) flutter/packages#2503

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 25, 2022

d71a8a7 [macOS] Bring up "hello_world" devicelab, compilation test fo…

1857413

…r x86. (flutter/flutter#109891)

cbracken reviewed Aug 25, 2022

View reviewed changes

engine-flutter-autoroll mentioned this pull request Aug 25, 2022

Roll Flutter from abfba69f8776 to 0d47af08a136 (67 revisions) flutter/plugins#6313

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 25, 2022

d71a8a7 [macOS] Bring up "hello_world" devicelab, compilation test fo…

a11fa62

…r x86. (flutter/flutter#109891)

engine-flutter-autoroll mentioned this pull request Aug 26, 2022

Roll Flutter from abfba69f8776 to 6d3f782fb004 (74 revisions) flutter/plugins#6314

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 26, 2022

d71a8a7 [macOS] Bring up "hello_world" devicelab, compilation test fo…

eb79df6

…r x86. (flutter/flutter#109891)

a-wallen mentioned this pull request Aug 26, 2022

Readability revisions for #109891 #110348

Merged

8 tasks

auto-submit bot pushed a commit that referenced this pull request Aug 29, 2022

Readability revisions for #109891 (#110348)

2f3ba1a

jmagman mentioned this pull request Aug 31, 2022

Do not run desktop benchmarks in presubmit #110642

Merged

8 tasks

		appPath: appBundlePath,
		operatingSystem: deviceOperatingSystem,

Conversation

a-wallen commented Aug 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reason

Related

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

yaakovschectman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

a-wallen commented Aug 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

jmagman Aug 24, 2022

Choose a reason for hiding this comment

Uh oh!

jmagman Aug 25, 2022

Choose a reason for hiding this comment

Uh oh!

a-wallen Aug 25, 2022

Choose a reason for hiding this comment

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

a-wallen commented Aug 19, 2022 •

edited

Loading

a-wallen commented Aug 23, 2022 •

edited

Loading