[flutter_tools] Enable custom devices on all channels#109953
Merged
zanderso merged 1 commit intoflutter:masterfrom Aug 21, 2022
Merged
[flutter_tools] Enable custom devices on all channels#109953zanderso merged 1 commit intoflutter:masterfrom
zanderso merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
Member
Author
|
cc @ardera |
jonahwilliams
approved these changes
Aug 21, 2022
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
BTW this still requires manually enabling the feature. If that is not a desired behavior, then enabledByDefault should also be set to true
Member
Author
|
I think we still want this to be under a config flag. |
zanderso
added a commit
to zanderso/flutter
that referenced
this pull request
Aug 21, 2022
This was referenced Aug 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 22, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 22, 2022
zanderso
added a commit
that referenced
this pull request
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the non-documentation component of #108787.