Re-Re-Land "Refactor StrokeAlign to allow double values." (#109805)" (#109955)"#109975
Re-Re-Land "Refactor StrokeAlign to allow double values." (#109805)" (#109955)"#109975bernaferrari wants to merge 3 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter#109805)" (flutter#109955)" This reverts commit 957a8da.
bernaferrari
force-pushed
the
StrokeAlign
branch
from
3314a4c to
c24bcdb
Compare
flutter-dashboard
bot
added
d: api docs
bernaferrari
force-pushed
the
StrokeAlign
branch
from
c24bcdb to
49fda96
Compare
bernaferrari
force-pushed
the
StrokeAlign
branch
from
49fda96 to
53c2c81
Compare
adilwahla
left a comment
adilwahla
left a comment
There was a problem hiding this comment.
Looks all okay make improvements by
- code refactoring
- combine repetitive code in one file & access through it
- Follow DRY (Don't Repeat yourself)
I hope it will help you alot :)
|
Super-seeded by another PR. |
3 participants
This tries to revert #109955 which is also followed by
b/243217872.This might fix the mysterious issue that is happening. Hopefully, someone can trigger Google Testing on this PR.
I'm trying two things
if (width == 0.0) break;in a commit,if (width == 0.0) drawRRect(the previous code) in another. First we test thedrawRRect, if it works, we try without drawRRect and see if it keeps passing. If nothing works, I'll close this PR and wait for the smart people to debug the issue.(this is kind of a draft, but I didn't find the button and I need the internal test)