[macOS] Bring up "complex_layout" devicelab, compilation test for x86 and arm64#110090
Conversation
fe1a661 to
63c915e
Compare
christopherfujino
left a comment
There was a problem hiding this comment.
had some style nits here; however, you should probably wait for our 1:1 before fixing any of these, as we can discuss high level strategy.
There was a problem hiding this comment.
why do you need to flush here? also, why unawaited?
There was a problem hiding this comment.
this can actually be final because of definite assignment analysis https://dart.dev/null-safety/understanding-null-safety#definite-assignment-analysis
There was a problem hiding this comment.
extension methods are against Flutter's style guide https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-using-extension
And I believe you can achieve the same effect now with Dart's new enhanced enum's: https://dart.dev/guides/language/language-tour#enumerated-types https://medium.com/dartlang/dart-2-17-b216bfc80c5d
63c915e to
cdd1895
Compare
cdd1895 to
2966884
Compare
From #109633
Fixes #110081
Pre-launch Checklist
///).