[macOS] Bring up "complex_layout" devicelab, startup tests for x64 by a-wallen · Pull Request #110100 · flutter/flutter

a-wallen · 2022-08-23T17:35:06Z

Reason

The initial desktop integration tests are running now, but they need to be expanded beyond the initial gallery build test; filing this to make sure that planned work is captured in the issue tracker. This should be much more straightforward that getting the first one running was, since the bot work is all complete.

In particular we should ensure we are testing building a freshly created project to catch errors in template changes. (I haven't checked where that test lives on existing platforms; it may be a device lab test, which still needs desktop bring-up).

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

dev/devicelab/lib/tasks/perf_tests.dart

yaakovschectman

LGTM

dev/benchmarks/complex_layout/windows/flutter/generated_plugin_registrant.cc

dev/benchmarks/complex_layout/macos/Runner/MainFlutterWindow.swift

dev/benchmarks/complex_layout/test/widget_test.dart

dev/benchmarks/complex_layout/macos/Runner/AppDelegate.swift

dev/benchmarks/complex_layout/.gitignore

cbracken

Update the title to just x64 for now since arm64 testing will depend on either (a) eliminating our reliance on x64 binaries under rosetta in our engine/tooling build products like gen_snapshot and libimobiledevice (b) getting rosetta on our machine images.

Of those, we're getting pushback on (b) and (a) is the better choice regardless.

…r x64 (flutter/flutter#110100)

flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 23, 2022

a-wallen changed the title ~~Macos bringup complex startup~~ [macOS] Bring up "complex_layout" devicelab, startup tests for x86 and arm64. Aug 23, 2022

a-wallen force-pushed the macos_bringup_complex_startup branch 3 times, most recently from 06f878f to 9e8c678 Compare August 24, 2022 23:02

a-wallen marked this pull request as ready for review August 25, 2022 00:35

a-wallen requested a review from keyonghan as a code owner August 25, 2022 00:35

a-wallen requested review from CaseyHillers, cbracken, jmagman and loic-sharma August 25, 2022 00:35

a-wallen assigned yaakovschectman and unassigned yaakovschectman Aug 25, 2022

a-wallen requested a review from yaakovschectman August 25, 2022 00:36

jmagman reviewed Aug 25, 2022

View reviewed changes

dev/devicelab/lib/tasks/perf_tests.dart Outdated Show resolved Hide resolved

yaakovschectman approved these changes Aug 25, 2022

View reviewed changes

a-wallen force-pushed the macos_bringup_complex_startup branch from 9e8c678 to cea1d32 Compare August 25, 2022 16:15

Implement runner for macOS startup tests

daf0af8

a-wallen force-pushed the macos_bringup_complex_startup branch 2 times, most recently from ddaa1c9 to a55054f Compare August 25, 2022 17:29