[Windows] Add app startup integration test#110114
Merged
loic-sharma merged 10 commits intoflutter:masterfrom Aug 26, 2022
Merged
[Windows] Add app startup integration test#110114loic-sharma merged 10 commits intoflutter:masterfrom
loic-sharma merged 10 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
loic-sharma
requested review from
a-wallen,
cbracken,
gspencergoog and
yaakovschectman
dev/integration_tests/windows_startup_test/test_driver/main_test.dart
Outdated
Show resolved
Hide resolved
yaakovschectman
approved these changes
Aug 23, 2022
Contributor
yaakovschectman
left a comment
yaakovschectman
left a comment
There was a problem hiding this comment.
LGTM code-wise other than failing tests, possibly all due to the one newline.
loic-sharma
commented
Aug 23, 2022
|
|
||
| Future<void> main() async { | ||
| deviceOperatingSystem = DeviceOperatingSystem.windows; | ||
| await task(createWindowsStartupDriverTest(deviceIdOverride: 'windows')); |
Member
Author
There was a problem hiding this comment.
Please let me know if this deviceIdOverride is unnecessary
a-wallen
reviewed
Aug 24, 2022
a-wallen
approved these changes
Aug 24, 2022
cbracken
reviewed
Aug 25, 2022
dev/integration_tests/windows_startup_test/windows/flutter/generated_plugin_registrant.cc
Outdated
Show resolved
Hide resolved
cbracken
reviewed
Aug 25, 2022
dev/integration_tests/windows_startup_test/windows/flutter/generated_plugins.cmake
Show resolved
Hide resolved
cbracken
reviewed
Aug 25, 2022
cbracken
reviewed
Aug 25, 2022
cbracken
reviewed
Aug 25, 2022
| MethodChannel('tests.flutter.dev/windows_startup_test'); | ||
|
|
||
| final bool? visible = await methodChannel.invokeMethod('isWindowVisible'); | ||
| if (visible == null || visible == false) { |
Member
There was a problem hiding this comment.
Shouldn't the window not be visible at startup (until beginFirstFrame)?
Member
Author
There was a problem hiding this comment.
(Sorry forgot to reply to this comment!)
Hiding the app's window until after the first frame was moved into its own pull request: #109816
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2022
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 26, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 29, 2022
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a basic integration test for the Windows's app startup. In a subsequent change (#109816), this test will be updated to verify the app's window isn't visible until after the first frame has been drawn.
Commits:
flutter create. No need to review this!Part of #41980
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.