Skip to content

Added backgroundColor and disabledBackgroundColor to SnackBarAction.#110338

Closed
chinmoy12c wants to merge 1 commit intoflutter:masterfrom
chinmoy12c:issue_109933
Closed

Added backgroundColor and disabledBackgroundColor to SnackBarAction.#110338
chinmoy12c wants to merge 1 commit intoflutter:masterfrom
chinmoy12c:issue_109933

Conversation

@chinmoy12c
Copy link
Member

@chinmoy12c chinmoy12c commented Aug 26, 2022

This PR adds backgroundColor and disabledBackgroundColor to SnackBarAction so it is possible to define custom background color to SnackBarAction Button.

Fixes: #109933

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 26, 2022
@chinmoy12c
Copy link
Member Author

chinmoy12c commented Aug 26, 2022 •
edited
Loading

I think these properties should also be added to SnackBarThemeData. IMO that should be added as a separate PR? @HansMuller are your thoughts on this?

@HansMuller
Copy link
Contributor

HansMuller commented Aug 26, 2022

Just one PR that added support for overriding the background color in terms of the widget and its theme would make sense. New state dependent values like backgroundColor should probably be defined with MaterialStateProperty<Color?>. A separate PR that added support for specifying a MaterialStateColor for textColor would also be helpful.

@chinmoy12c chinmoy12c mentioned this pull request Aug 27, 2022
Closed
pdblasi-google
pdblasi-google suggested changes Aug 29, 2022
View reviewed changes
@chinmoy12c chinmoy12c force-pushed the issue_109933 branch 3 times, most recently from 4ab4745 to dc11224 Compare August 30, 2022 05:45
pdblasi-google
pdblasi-google approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@pdblasi-google pdblasi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

HansMuller
HansMuller reviewed Sep 6, 2022
View reviewed changes
@HansMuller
Copy link
Contributor

HansMuller commented Dec 3, 2022

I'm closing this for now, because it hasn't been worked on in a while. Please reopen if you decide to resume working on it.

@HansMuller HansMuller closed this Dec 3, 2022
@chinmoy12c
Copy link
Member Author

chinmoy12c commented Jan 18, 2023

Hey @HansMuller, I've updated the branch of this issue with the changes, sorry for the delay. Could you please reopen this PR.

@HansMuller
Copy link
Contributor

HansMuller commented Jan 18, 2023

It looked like I can't reopen the PR. If you can't either, then it might be simplest to create a new one.
Screenshot 2023-01-18 at 1 58 29 PM

@chinmoy12c
Copy link
Member Author

chinmoy12c commented Jan 19, 2023 •
edited
Loading

Hey @HansMuller, I've opened a new PR here: #118786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HansMuller HansMuller Awaiting requested review from HansMuller

1 more reviewer

@pdblasi-google pdblasi-google pdblasi-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support to set background color of SnackBarAction when clicked

3 participants

@chinmoy12c @HansMuller @pdblasi-google