Skip to content

Revert "[macOS] Bring up "flutter_gallery" devicelab, start up test for x86."#110372

Merged
christopherfujino merged 1 commit intomasterfrom
revert-110370-macos_bringup_gallery_startup
Aug 26, 2022
Merged

Revert "[macOS] Bring up "flutter_gallery" devicelab, start up test for x86."#110372
christopherfujino merged 1 commit intomasterfrom
revert-110370-macos_bringup_gallery_startup

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 26, 2022

Reverts #110370

This closed the tree: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_android%20flutter_gallery_mac__start_up/3652/overview

I'm not sure why it broke Mac_android flutter_gallery_mac__start_up since the breaking PR added Mac flutter_gallery_macos__start_up. Maybe a naming conflict?

@jmagman jmagman requested a review from a-wallen August 26, 2022 20:42
@jmagman jmagman requested a review from keyonghan as a code owner August 26, 2022 20:42
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 26, 2022
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Contributor

I think renaming the task broke the other target which also depended on that file

@christopherfujino
Copy link
Contributor

as this is a revert on ToT to fix tree, merging before pre-submits finish.

@christopherfujino christopherfujino merged commit d65d64d into master Aug 26, 2022
@christopherfujino christopherfujino deleted the revert-110370-macos_bringup_gallery_startup branch August 26, 2022 20:48
@jmagman
Copy link
Member Author

jmagman commented Aug 26, 2022

https://github.com/flutter/flutter/pull/110370/files#r956438689

dev/devicelab/bin/tasks/flutter_gallery_mac__start_up.dart test was for Android Mac_android flutter_gallery_mac__start_up. The rename to flutter_gallery_macos__start_up.dart broke that test.

flutter/.ci.yaml

Line 3084 in 4770e34

task_name: flutter_gallery_mac__start_up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants