Make module tests pass on Xcode 14#110556
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Aug 30, 2022
Merged
Conversation
jmagman
added
platform-ios
flutter-dashboard
bot
added
the
c: contributor-productivity
jmagman
commented
Aug 30, 2022
| checkFileExists(simulatorFrameworkHeaderPath); | ||
| } | ||
|
|
||
| checkDirectoryExists(path.join( |
Member
Author
There was a problem hiding this comment.
BCSymbolMaps is a bitcode thing, and is no longer generated in Xcode 14.
10 tasks
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
arm64_armv7directories and bitcode checks for built/embedded frameworks. Leave the bitcode checks for Flutter.framework and App.framework, to be removed later as part of #107887.Tested locally on Xcode 14 beta 5.
Fixes #110555
Fixes #110553
Reverts the unnecessary armv7 checks from #101592 post-#97327.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.