Null safety migration of packages/flutter_tools/bin#110706
Merged
liamappelbe merged 17 commits intoflutter:masterfrom Sep 12, 2022
Merged
Null safety migration of packages/flutter_tools/bin#110706liamappelbe merged 17 commits intoflutter:masterfrom
liamappelbe merged 17 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
Contributor
Author
|
Blocked on dwds migration |
Contributor
Author
|
Tests are passing |
| globals.fs.currentDirectory = testDirectory.parent; | ||
| globals.fs.currentDirectory = testDirectory!.parent; | ||
| } else { | ||
| globals.fs.currentDirectory = testDirectory; |
Contributor
There was a problem hiding this comment.
Suggested change
| globals.fs.currentDirectory = testDirectory; | |
| globals.fs.currentDirectory = testDirectory!; |
Contributor
Author
There was a problem hiding this comment.
I tried that, but the analyzer complains that this is an unnecessary assertion.
Contributor
There was a problem hiding this comment.
I see, I guess because set currentDirectory takes a dynamic. This is fine.
This was referenced Sep 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 13, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Null safety migration of packages/flutter_tools/bin