Null safety migration of packages/flutter_tools/test/general.shard, part 1/2#110711
Merged
liamappelbe merged 10 commits intoflutter:masterfrom Sep 8, 2022
Merged
Null safety migration of packages/flutter_tools/test/general.shard, part 1/2#110711liamappelbe merged 10 commits intoflutter:masterfrom
liamappelbe merged 10 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
liamappelbe
added a commit
to liamappelbe/flutter
that referenced
this pull request
Sep 7, 2022
Contributor
Author
|
Tests are passing |
| expect(lines[0], equals('All good.')); | ||
| }); | ||
|
|
||
| testWithoutContext('Stdout printStatus handle null inputs on colored terminal', () async { |
Contributor
There was a problem hiding this comment.
Is this no longer a legitimate test?
Contributor
Author
There was a problem hiding this comment.
You can't pass null to Logger.printStatus anymore.
This was referenced Sep 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 9, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 9, 2022
liamappelbe
added a commit
that referenced
this pull request
Sep 12, 2022
* Migrate packages/flutter_tools/bin * Fix NPE * Fix test * Fix test * Fix l10n optionalParameters * Fix ChromeTab nullability * Fix another type cast error * Fix another cast error * Fix another cast error (copied from #110711) * Fix NPE * Fix another NPE * Assert that testDirectory is not null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Null safety migration of packages/flutter_tools/test/general.shard, part 1/2