[macOS] Add platform_view example.#111005
Merged
auto-submit[bot] merged 13 commits intoflutter:masterfrom Sep 7, 2022
Merged
Conversation
flutter-dashboard
bot
added
d: examples
8 tasks
added 13 commits
September 6, 2022 10:28
a-wallen
force-pushed
the
macos_platform_view_example
branch
from
b7de5ae to
705dd7d
Compare
loic-sharma
approved these changes
Sep 6, 2022
Member
loic-sharma
left a comment
loic-sharma
left a comment
There was a problem hiding this comment.
Looks reasonable to me but consider getting approval from someone that's more familiar with macOS!
8 tasks
jmagman
approved these changes
Sep 7, 2022
a-wallen
added
the
autosubmit
cbracken
reviewed
Sep 7, 2022
|
|
||
| import Cocoa | ||
|
|
||
| class PlatformViewController: NSViewController { |
Member
There was a problem hiding this comment.
nit: add a doc comment, especially since it's an example.
This was referenced Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an implementation for
platform_viewon macOS for better example coverage and for device lab tests.Screen.Recording.2022-09-05.at.11.10.40.AM.mov
Issues #111004
Pre-launch Checklist
///).