Fix DraggableScrollableSheet rebuilding during drag#111010
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Sep 13, 2022
Merged
Fix DraggableScrollableSheet rebuilding during drag#111010auto-submit[bot] merged 2 commits intoflutter:masterfrom
auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: scrolling
|
I need this. |
xu-baolin
reviewed
Sep 6, 2022
| // If an external facing controller was provided, let it know that the | ||
| // extent has been replaced. | ||
| widget.controller?._onExtentReplaced(previousExtent); | ||
| if (widget.controller?.isAttached ?? false) { |
Member
There was a problem hiding this comment.
I'm curious why the new controller doesn't attached now?
Contributor
Author
There was a problem hiding this comment.
Actually, I realized that new controller is still not handled properly (_attach is only called in initState, never if we have a new controller). This isn't really related to my change, I found it while writing the test, where I wanted to show that builder was still called when we have a new controller. Going to update the changeset with proper change for giving a new controller.
Member
There was a problem hiding this comment.
So this maybe another issue we should fix, right?
Maybe we should fix it in a separate file instead of temporarily circumventing it.
|
Any updates on this fix? |
moffatman
force-pushed
the
draggable_sheet
branch
from
51a4dc8 to
bfd3289
Compare
moffatman
added
the
autosubmit
This was referenced Sep 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 14, 2022
CaseyHillers
pushed a commit
that referenced
this pull request
Sep 23, 2022
This was referenced Sep 27, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DraggableScrollableSheetwas rebuilding every time the size of the child changed, which meant every frame during a drag. Now it will only rebuild when it gets changed parameters from the parent widget.Also inadvertent fix to an exception thrown while rebuilding
DraggableScrollableSheetwith a new controller.Fixes #67219
Pre-launch Checklist
///).