Skip to content

[macOS] Add platform_view_macos__start_up tests devicelab test suite.#111041

Merged
auto-submit[bot] merged 4 commits intoflutter:masterfrom
a-wallen:macos_bringup_platform_view_start_up
Sep 8, 2022
Merged

[macOS] Add platform_view_macos__start_up tests devicelab test suite.#111041
auto-submit[bot] merged 4 commits intoflutter:masterfrom
a-wallen:macos_bringup_platform_view_start_up

Conversation

@a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Sep 6, 2022

There were very few benchmark device lab tests on macOS up until this point. See the parent issue for the list of tests we were trying to bring up now.

Land after: #111005

Fixes #110086

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 6, 2022
@a-wallen a-wallen marked this pull request as ready for review September 7, 2022 18:13
@a-wallen a-wallen requested a review from keyonghan as a code owner September 7, 2022 18:13
@a-wallen a-wallen requested a review from cbracken September 8, 2022 16:45
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

lgtm but looks like you'll need to rebase to deal with a conflict in TESTOWNERS.

@a-wallen a-wallen force-pushed the macos_bringup_platform_view_start_up branch from 7762357 to 0ea0d47 Compare September 8, 2022 17:24
@a-wallen a-wallen force-pushed the macos_bringup_platform_view_start_up branch from 0ea0d47 to f9da86f Compare September 8, 2022 17:31
@a-wallen a-wallen added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 8, 2022
@auto-submit auto-submit bot merged commit 652ff7a into flutter:master Sep 8, 2022
@a-wallen a-wallen deleted the macos_bringup_platform_view_start_up branch September 8, 2022 19:35
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 9, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 9, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 9, 2022
@jmagman
Copy link
Member

jmagman commented Sep 9, 2022

This is failing: #111297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[macOS] Bring up "platform_view" devicelab, startup tests for x86.

3 participants