[web] skip flaky date picker golden tests#111114
[web] skip flaky date picker golden tests#111114auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: cupertino
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| // TODO(yjbanov): on the web text rendered with perspective produces flaky goldens: https://github.com/flutter/flutter/issues/110785 | ||
| const bool doNotSkipPerspectiveTextGoldens = !isBrowser; |
There was a problem hiding this comment.
nit: might be clearer if this is skipPerspectiveTextGoldens = isBrowser
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
3 participants
Skip flaky date picker golden tests on the web to unblock the CanvasKit 0.36.1 roll, which brings a much needed fix for some Android GPUs that fail render text using the old method Skia used (b/229626353).