Skip to content

Remove flutter_gallery_mac__start_up as target in .ci.yaml#111117

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
a-wallen:remove_flutter_gallery_mac__start_up
Sep 7, 2022
Merged

Remove flutter_gallery_mac__start_up as target in .ci.yaml#111117
auto-submit[bot] merged 2 commits intoflutter:masterfrom
a-wallen:remove_flutter_gallery_mac__start_up

Conversation

@a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Sep 7, 2022 •
edited
Loading

This PR removes flutter_gallery_mac__start_up and all references to it. Since we have other tests/benchmarks that can launch an Android app from a mac host, we can just delete flutter_gallery_mac__start_up. This will eliminate the confusion once flutter_gallery_macos__start_up is landed as a perf test for macOS.

Fixes #111115

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 7, 2022
@a-wallen a-wallen marked this pull request as ready for review September 7, 2022 17:59
@a-wallen a-wallen requested a review from keyonghan as a code owner September 7, 2022 17:59
@a-wallen a-wallen requested a review from jmagman September 7, 2022 17:59
jmagman
jmagman approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion in #110379 (comment)

cc @zanderso

LGTM

jmagman
jmagman reviewed Sep 7, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, @keyonghan is there still the issue we need to remove the test from the .ci.yaml, let it roll, and then it's safe to delete the test file?

@keyonghan
Copy link
Contributor

keyonghan commented Sep 7, 2022

Actually, @keyonghan is there still the issue we need to remove the test from the .ci.yaml, let it roll, and then it's safe to delete the test file?

Yeah, we are still having that issue as the ci roller is still in use. As said, we need to remove the target first, and then the files. Otherwise it will cause a short time of tree red if the target is scheduled before the roller lands.

@a-wallen a-wallen force-pushed the remove_flutter_gallery_mac__start_up branch from 11cd90c to e565739 Compare September 7, 2022 18:47
@a-wallen
Copy link
Contributor Author

a-wallen commented Sep 7, 2022

@keyonghan alright, I dropped the commit that removed the file. I'll follow up in another PR to delete that file.

keyonghan
keyonghan approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-wallen
Copy link
Contributor Author

a-wallen commented Sep 7, 2022 •
edited
Loading

Opening an issue to track the deletion of the file and mark this as fully completed.

#111143

@a-wallen a-wallen added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 7, 2022
@auto-submit auto-submit bot merged commit 2b37390 into flutter:master Sep 7, 2022
@a-wallen a-wallen deleted the remove_flutter_gallery_mac__start_up branch September 7, 2022 22:19
This was referenced Sep 7, 2022
Closed
Merged
Merged
This was referenced Sep 8, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
2b37390 Remove flutter_gallery_mac__start_up as target in .ci.yaml (f…
78e076d 
…lutter/flutter#111117)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
2b37390 Remove flutter_gallery_mac__start_up as target in .ci.yaml (f…
60d9da5 
…lutter/flutter#111117)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 8, 2022
@engine-flutter-autoroll
2b37390 Remove flutter_gallery_mac__start_up as target in .ci.yaml (f…
d150da5 
…lutter/flutter#111117)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

+1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove flutter_gallery_mac__start_up devicelab test.

3 participants

@a-wallen @keyonghan @jmagman