[platform_view]use cmd to uninstall the app#111139
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Sep 7, 2022
Merged
[platform_view]use cmd to uninstall the app#111139auto-submit[bot] merged 1 commit intoflutter:masterfrom
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
hellohuanlin
force-pushed
the
platform_view_use_cmd_to_uninstall
branch
from
868c676 to
ff1e10a
Compare
hellohuanlin
force-pushed
the
platform_view_use_cmd_to_uninstall
branch
from
ff1e10a to
85b8f0a
Compare
jmagman
approved these changes
Sep 7, 2022
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
LGTM, thanks for circling back on this. If it gets flaky again I give up, let's go back to the hack and move on.
Contributor
Author
|
finger crossed: https://chromium-swarm.appspot.com/task?id=5d32c1d1a13cbe10 |
cyanglaz
approved these changes
Sep 7, 2022
|
|
||
| await inDirectory(projectDirectory, () async { | ||
|
|
||
| // To address "Failed to terminate" failure. |
Contributor
Author
There was a problem hiding this comment.
oops. it got landed before my force push. will just leave it as it is.
hellohuanlin
added
the
autosubmit
This was referenced Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 8, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can simply uninstall using the flutter command, as pointed out by @jmagman
led: https://chromium-swarm.appspot.com/task?id=5d32c1d1a13cbe10
Fixes #109697
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.