Skip to content

Enable android isolate platform channels tests#111279

Merged
gaaclarke merged 1 commit intoflutter:masterfrom
gaaclarke:enable-android-isolate-platform-channels
Sep 13, 2022
Merged

Enable android isolate platform channels tests#111279
gaaclarke merged 1 commit intoflutter:masterfrom
gaaclarke:enable-android-isolate-platform-channels

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Sep 9, 2022 •
edited
Loading

companion engine pr: flutter/engine#35804
issue: #13937

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 9, 2022
@gaaclarke gaaclarke changed the title Enable android isolate platform channels Enable android isolate platform channels tests Sep 9, 2022
@gaaclarke gaaclarke mentioned this pull request Sep 9, 2022
Closed
11 tasks
@gaaclarke gaaclarke force-pushed the enable-android-isolate-platform-channels branch 2 times, most recently from 023bf7d to d4b31db Compare September 12, 2022 17:59
@gaaclarke gaaclarke force-pushed the enable-android-isolate-platform-channels branch from d4b31db to 73f6ed5 Compare September 12, 2022 18:25
@gaaclarke gaaclarke mentioned this pull request Sep 12, 2022
Merged
8 tasks
@gaaclarke gaaclarke marked this pull request as ready for review September 12, 2022 20:38
@gaaclarke gaaclarke requested a review from dnfield September 12, 2022 20:38
@gaaclarke gaaclarke merged commit 71b4797 into flutter:master Sep 13, 2022
This was referenced Sep 14, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 14, 2022
@engine-flutter-autoroll
71b4797 turned on background isolate platform channel tests for andro…
0693a9c 
…id (flutter/flutter#111279)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 14, 2022
@engine-flutter-autoroll
71b4797 turned on background isolate platform channel tests for andro…
ae8172e 
…id (flutter/flutter#111279)
gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Sep 15, 2022
@gaaclarke
Revert "turned on background isolate platform channel tests for andro…
34bd5eb 
…id (flutter#111279)"

This reverts commit 71b4797.
gaaclarke added a commit that referenced this pull request Sep 15, 2022
@gaaclarke
Revert isolate platform channels because of google integration tooling (
12506ed 
#111702)

* Revert "turned on background isolate platform channel tests for android (#111279)"

This reverts commit 71b4797.

* Revert "Reland: Started handling messages from background isolates. (#111320)"

This reverts commit 1ad2757.
gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Sep 16, 2022
@gaaclarke
turned on background isolate platform channel tests for android (flut…
91608dd 
…ter#111279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaaclarke @dnfield