Skip to content

Reland: Started handling messages from background isolates.#111320

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
gaaclarke:reland-isolate-platform-channels
Sep 12, 2022
Merged

Reland: Started handling messages from background isolates.#111320
auto-submit[bot] merged 2 commits intoflutter:masterfrom
gaaclarke:reland-isolate-platform-channels

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Sep 9, 2022 •
edited
Loading

Previously this landed with the integration test broken and it wasn't caught in presubmit. This fixes the integration test.

relands #109005
issue: #13937

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Sep 9, 2022
@gaaclarke gaaclarke mentioned this pull request Sep 9, 2022
Closed
11 tasks
@gaaclarke
Copy link
Member Author

gaaclarke commented Sep 10, 2022

The breakage happened when I introduced useBackgroundIsolateBinaryMessenger. That gave us the ability to mock out the behavior, but also left us talking to ServicesBindings from a background isolate which we don't want.

@gaaclarke gaaclarke force-pushed the reland-isolate-platform-channels branch from 5ab7ac3 to a89cb6f Compare September 10, 2022 04:05
@gaaclarke gaaclarke marked this pull request as ready for review September 10, 2022 04:43
@gaaclarke gaaclarke requested a review from dnfield September 10, 2022 04:43
@gaaclarke
Copy link
Member Author

gaaclarke commented Sep 10, 2022

@dnfield in order to fix the integration test I had to remove useBackgroundIsolateBinaryMessenger. I forgot that ServiceBinding wouldn't be available on background threads so we can't mock it out that way. Now that function is just inlined. This is similar to how it was before but it has the added check for web.

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2022
@auto-submit auto-submit bot merged commit 1ad2757 into flutter:master Sep 12, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 12, 2022
@engine-flutter-autoroll
1ad2757 Reland: Started handling messages from background isolates. (f…
451fe11 
…lutter/flutter#111320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 12, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2022
@engine-flutter-autoroll
1ad2757 Reland: Started handling messages from background isolates. (f…
105b66e 
…lutter/flutter#111320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 13, 2022
@engine-flutter-autoroll
1ad2757 Reland: Started handling messages from background isolates. (f…
f71ae4f 
…lutter/flutter#111320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 13, 2022
@engine-flutter-autoroll
1ad2757 Reland: Started handling messages from background isolates. (f…
9b6aa03 
…lutter/flutter#111320)
@gaaclarke gaaclarke mentioned this pull request Sep 15, 2022
Open
gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Sep 15, 2022
@gaaclarke
Revert "Reland: Started handling messages from background isolates. (f…
9dbdb17 
…lutter#111320)"

This reverts commit 1ad2757.
gaaclarke added a commit that referenced this pull request Sep 15, 2022
@gaaclarke
Revert isolate platform channels because of google integration tooling (
12506ed 
#111702)

* Revert "turned on background isolate platform channel tests for android (#111279)"

This reverts commit 71b4797.

* Revert "Reland: Started handling messages from background isolates. (#111320)"

This reverts commit 1ad2757.
gaaclarke added a commit to gaaclarke/flutter that referenced this pull request Sep 16, 2022
@gaaclarke
Reland: Started handling messages from background isolates. (flutter#…
018ddb0 
…111320)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaaclarke @dnfield