Skip to content

Fix changing DraggableScrollableSheet controller#111445

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
moffatman:draggable_sheet_2
Sep 16, 2022
Merged

Fix changing DraggableScrollableSheet controller#111445
auto-submit[bot] merged 1 commit intoflutter:masterfrom
moffatman:draggable_sheet_2

Conversation

@moffatman
Copy link
Contributor

@moffatman moffatman commented Sep 13, 2022

Right now if you swap the controller, it will cause a lot of assertion failures. We need to properly detach from old controller and attach to the new one.

Found while fixing #67219

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Sep 13, 2022
@moffatman moffatman mentioned this pull request Sep 13, 2022
Merged
8 tasks
Piinks
Piinks approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, @xubaolin has been working a lot in this area too, FYI.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 16, 2022
@auto-submit auto-submit bot merged commit 0322b57 into flutter:master Sep 16, 2022
This was referenced Sep 17, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 17, 2022
@engine-flutter-autoroll
0322b57 Fix changing DraggableScrollableSheet controller (flutter/flu…
db8c791 
…tter#111445)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 17, 2022
@engine-flutter-autoroll
0322b57 Fix changing DraggableScrollableSheet controller (flutter/flu…
2522831 
…tter#111445)
@Piinks Piinks mentioned this pull request Sep 21, 2022
Closed
@xu-baolin xu-baolin mentioned this pull request Sep 22, 2022
Merged
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request Sep 23, 2022
Revert "Fix changing DraggableScrollableSheet controller (flutter#111445
f7c17b5 
)"

This reverts commit 0322b57.
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request Sep 23, 2022
Revert "Fix changing DraggableScrollableSheet controller (flutter#111445
4029266 
)"

This reverts commit 0322b57.
CaseyHillers pushed a commit that referenced this pull request Sep 23, 2022
[releases] Revert DraggableScrollableSheet controller changes (#112294)
542b30b 
* Revert "Fix changing DraggableScrollableSheet controller (#111445)"

This reverts commit 0322b57.

* Revert "Fix DraggableScrollableSheet rebuilding during drag (#111010)"

This reverts commit 7b5241b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@thkim1011 thkim1011 Awaiting requested review from thkim1011

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moffatman @Piinks