Startup flutter faster (faster wrapper script on Windows)#111465
Merged
jensjoha merged 1 commit intoflutter:masterfrom Sep 19, 2022
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
|
Benchmarks are running: https://flutter-flutter-perf.skia.org/e/?queries=test%3Dflutter_tool_startup__linux |
This was referenced Sep 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 19, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
flutter(as measured withflutter testdirectly in theflutterdirectory which has notestdirectory, thus just writing "there's notestdirectory) startup faster by improving the Windows wrapper script.When executing
flutterin Windows, really it's the bat scriptflutter.batthat's executed.This makes sure the user has git installed, there's a git checkout etc.
Specifically it does these things which it doesn't really need to:
gitis installed and runs agitcommand. These can be merged because agitcommand will fail if there is no git.This PR does exactly that, improving startup time quite significant, see below.
This PR stacks with #111392, #111459 and #111461.
Windows (Google issued with whatever security software)
I.e. this PR alone:
And stacked with #111392, #111459 and #111461:
A more detailed analysis is available internally at go/FlutterStartupTimeAnalysis.