Reland "Migrate android_semantics_testing to null safety (#111420)"#111487
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Sep 13, 2022
Merged
Reland "Migrate android_semantics_testing to null safety (#111420)"#111487auto-submit[bot] merged 2 commits intoflutter:masterfrom
auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
)" This reverts commit e993419.
This was referenced Sep 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The error message seems to indicate there is exception thrown when running the matcher. The error message gets swallowed because the describeMismatch assumes the matchState always contains the failure message, which may not be the case if the match does no finish successfully.
This pr add two things:
The AndroidSemanticsNode.isHeader is only available above certain Android version, and it is likely the motog4 in devices lab is below the android version, which may be the reason the matcher crash in the first place.
The changes are in the second commit.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.