Provide Material 3 defaults for vanilla Chip widget.#111597
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom Sep 19, 2022
darrenaustin:m3_vanilla_chip_defaults
Merged
Provide Material 3 defaults for vanilla Chip widget.#111597auto-submit[bot] merged 1 commit intoflutter:masterfrom darrenaustin:m3_vanilla_chip_defaults
Chip widget.#111597auto-submit[bot] merged 1 commit intoflutter:masterfrom
darrenaustin:m3_vanilla_chip_defaults
Conversation
flutter-dashboard
bot
added
f: material design
guidezpl
approved these changes
Sep 15, 2022
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
HansMuller
approved these changes
Sep 15, 2022
darrenaustin
added
the
autosubmit
This was referenced Sep 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Material 3 doesn't provide a "default" chip, but we have a
Chipwidget base class that some may be using. This PR just adds the 'Assist' chip's defaults for M3 to the base class.Also optimized the code generation for shapes to make the rounded rect case a little cleaner.
Fixes: #109470
Pre-launch Checklist
///).