Add flutter startup benchmark#111658
Merged
jensjoha merged 6 commits intoflutter:masterfrom Sep 16, 2022
Merged
Conversation
flutter-dashboard
bot
added
the
c: contributor-productivity
keyonghan
reviewed
Sep 15, 2022
Contributor
There was a problem hiding this comment.
I don't know if there's any way of verifying that it works, though?
You can validate in different ways:
- locally: https://github.com/flutter/flutter/tree/master/dev/devicelab#running-tests-locally
- via
ledrun: go/flutter-luci-recipes#testing-a-local-change-for-a-new-builderrecipe
jonahwilliams
approved these changes
Sep 15, 2022
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM to me, but wait for @keyonghan too.
If they happen to fail on CI, they're marked bringup so they won't close the tree and we can investigate afterwards
keyonghan
reviewed
Sep 15, 2022
jensjoha
force-pushed
the
flutter_startup_benchmark
branch
from
e4dc471 to
7ee093f
Compare
Contributor
Author
I have tested it locally (on Linux) --- but from there to knowing that it shows up correctly somewhere (with being tested on actual Windows, Linux and Mac etc) is quite a leap =) |
keyonghan
reviewed
Sep 15, 2022
This was referenced Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 16, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt of adding a flutter startup benchmark as directed on
#111461 (comment)
I don't know if there's any way of verifying that it works, though?